From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D74C2B9F4 for ; Tue, 22 Jun 2021 11:40:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0EB96113E for ; Tue, 22 Jun 2021 11:40:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0EB96113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvelr-00026q-Gb for qemu-devel@archiver.kernel.org; Tue, 22 Jun 2021 07:40:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvekl-0001NO-VD for qemu-devel@nongnu.org; Tue, 22 Jun 2021 07:39:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvekg-0008IJ-HE for qemu-devel@nongnu.org; Tue, 22 Jun 2021 07:39:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624361972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E0fHC3xpiuljkeyRcWuxCK2uYsIQiekc3LIkfsLPQYA=; b=M0V3iHv5os+evD5/pCBwfORsW2FP/uv84dgCSL6EahXOMyTuWiTavtZvQVjVBo4LT/4lSX O/pGUPYmo+rNBEBc9x+i+b2+7Ay6DLVwHe1Mc30nZbuFYFZkLPuzyEKxIzBiNxDYp1KqV4 eUVHCvT0T7KOyo5abPnTFt9BNsbax8w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-9vyCyISqMtWe5QrPH7RHIw-1; Tue, 22 Jun 2021 07:39:28 -0400 X-MC-Unique: 9vyCyISqMtWe5QrPH7RHIw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 66BE881C861; Tue, 22 Jun 2021 11:39:27 +0000 (UTC) Received: from localhost (ovpn-113-161.ams2.redhat.com [10.36.113.161]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4D38619C79; Tue, 22 Jun 2021 11:39:23 +0000 (UTC) From: Cornelia Huck To: "Cho, Yu-Chen" , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Subject: Re: [RFC v5 06/13] target/s390x: start moving TCG-only code to tcg/ In-Reply-To: <20210622101726.20860-7-acho@suse.com> Organization: Red Hat GmbH References: <20210622101726.20860-1-acho@suse.com> <20210622101726.20860-7-acho@suse.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Tue, 22 Jun 2021 13:39:21 +0200 Message-ID: <87czsenn6e.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.223, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cfontana@suse.com, David Hildenbrand , acho@suse.com, Claudio Fontana Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jun 22 2021, "Cho, Yu-Chen" wrote: > move everything related to translate, as well as HELPER code in tcg/ > > mmu_helper.c stays put for now, as it contains both TCG and KVM code. > > The internal.h file is renamed to s390x-internal.h, because of the > risk of collision with other files with the same name. > > After the reshuffling, update MAINTAINERS accordingly. > Make use of the new directory: > > target/s390x/tcg/ (...) > diff --git a/MAINTAINERS b/MAINTAINERS > index 636bf2f536..d05dcc22e0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -294,7 +294,7 @@ S390 TCG CPUs > M: Richard Henderson > M: David Hildenbrand > S: Maintained > -F: target/s390x/ > +F: target/s390x/tcg > F: hw/s390x/ > F: disas/s390.c > F: tests/tcg/s390x/ This means that the pattern for tcg won't cover those files anymore that are relevant for both tcg and kvm (e.g. cpu models). Maybe those files need to be enumerated? Or keep the old pattern?