From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93992C433E0 for ; Mon, 8 Mar 2021 17:38:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 023FD65100 for ; Mon, 8 Mar 2021 17:38:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 023FD65100 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJJqF-0004yE-VH for qemu-devel@archiver.kernel.org; Mon, 08 Mar 2021 12:38:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJJfw-0000UI-K2; Mon, 08 Mar 2021 12:28:12 -0500 Received: from home.keithp.com ([63.227.221.253]:49434 helo=elaine.keithp.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJJfu-0004tD-2c; Mon, 08 Mar 2021 12:28:12 -0500 Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id 048203F2EDF3; Mon, 8 Mar 2021 09:28:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1615224485; bh=m+sw0Zt/ees661/3Rr4sQMtlM3GlrM7DNfMqo1u+8RM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YG/ZVXMGmDITTxUCT2GXnlZoFpKkAAp/PBRZkjxVYwtrsl1BcFaKFvdrzBLmAmHh7 pl7vp9SqctV7r0qPpxWXWA/KYzLKOy9EEfMy4HZ/gcgQRaii42gRnuBvEU1/3Vbyul D5dM3gOZ2baZar4I69Qo9nKF3w4IX9dDdsguGIgiD74ez9h8dHtV30B5A5xG1DdK0a HkVHkM0NlTeWpkfnKZERQltSxc3Uwv253xCBfbmScoRc4rKfwqy975W7ElHbknxGcr 5weFh0XD87jihSm4fgLdirQVE0m4UVZ6M6mysqpESIESJ8ENp46DA6Z9Ekwa8KIG/S 2cWRgaWqurrLg== X-Virus-Scanned: Debian amavisd-new at keithp.com Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GqbDHdoCU_hc; Mon, 8 Mar 2021 09:28:04 -0800 (PST) Received: from keithp.com (koto.keithp.com [10.0.0.2]) by elaine.keithp.com (Postfix) with ESMTPSA id AF4643F2EDEC; Mon, 8 Mar 2021 09:28:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1615224484; bh=m+sw0Zt/ees661/3Rr4sQMtlM3GlrM7DNfMqo1u+8RM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RO8IMNNDZ51kjFPnj4Wdn5F8wnDaCPXbBY07C2ztSR4rr6a3pdLt/visRgSY1Zz8k UOxHNlWeOsyk8kSsU7vbKC1C7D6ugw1FuvRiZiyHlrf4XIwvMrLpo7zX5tn0t6oiVu I9lQDGh/0OaZkPra24h/gxFRYCyWTFiQuCnyLJieRzthz5U5RanSgz9CI5K/R/Nelp 81/0Rg4nV3hila0fjeNuscU430t/dbw9UosTptpPZSpwsTcqTUhrnW5rmrHbn3zeUk 3Q6UOoOS79vsnia9wgDyXgBwFXrz62LtFfeTYvBneaD39ht+w2kUspJ37f5XDNIG6t jJ/jd7PXOkAaw== Received: by keithp.com (Postfix, from userid 1000) id A7F7A15821A3; Mon, 8 Mar 2021 09:28:04 -0800 (PST) To: Alistair Francis , Peter Maydell Cc: Alex =?utf-8?Q?Benn=C3=A9e?= , QEMU Developers , Bug 1915925 <1915925@bugs.launchpad.net>, "open list:ARM TCG CPUs" Subject: Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO In-Reply-To: References: <20210305135451.15427-1-alex.bennee@linaro.org> <20210305135451.15427-4-alex.bennee@linaro.org> <87im65gxla.fsf@keithp.com> <877dmlgnrf.fsf@keithp.com> <87o8fwfcjd.fsf@keithp.com> Date: Mon, 08 Mar 2021 09:28:04 -0800 Message-ID: <87czw9ftcr.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Received-SPF: pass client-ip=63.227.221.253; envelope-from=keithp@keithp.com; helo=elaine.keithp.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Keith Packard From: Keith Packard via --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alistair Francis writes: > I have started on the effort, but I have not finished yet. Adding > riscv_cpu_is_32bit() was the first step there and I have some more > patches locally but I don't have anything working yet. That's awesome. I think waiting until we see what APIs you're developing for detecting and operating in 32-bit mode on a 64-bit capable processor seems like a good idea for now. =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAmBGXqQACgkQ2yIaaQAA ABG7Aw/9EA9NUbXRwNYs14zkycnnoFVFGS6Y3NmnDBeJ4h6WqQaAvMVFg/jVB2AX 4q4SZsakKc35H+i9icj/lBpBmdVySUI/kJ+elElE5IVYM47msBBGYb8KmX1f1n1F twgWduMjHi4KoPbitIl1OtCr8/oNkddBKmPsEG/kYdxmZU1bdKg+YYSNjUZd80JV JHb1uAyAZLLBGLKEjm6ZrfJGgDPDzik+nuLieVn9pAkPUhUSr2/a+ZGjcMFIJMxv ws1OOQmsjgR25yHk004yRqXgueS1MneXC9ri7cN/NbkbiKFMKrzvJKP5susTs8wi ltZ0CLiYmKt/VaNnEx4xzBUwR/o+7ML4bxOSjxaWCazRQPi/HV3b0h/+XzLl0LjM KEGDLpVLEw87tNIkRBdQYvAuZbFG+WwqOBE+y0U+JhS5rZzLJijZUnOs48Y84kVE dpBdHZiOclU9b1p1zTLi0+Nv/9dFZBZOPXBWwdsGvn5ExYU4oFLutBxws3UP9TBW r5LuqphhzvHN70yu56hSH9Clbhi4k5NacZft/7PS+v2K9lszQs9ndbvmFqr8T1qY SldfyUI1hZixUMyQPMFcaSsHq5Xo4PJOdgtNdBsSO03wv7cSla7XaqeRBdAcVScw ESl3K0bO7sZRlDy4xGuYOu2xNcRt2tLctYjZiRZvpMsYo6pxFwo= =kcrR -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3566C433E0 for ; Mon, 8 Mar 2021 18:38:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BC866516B for ; Mon, 8 Mar 2021 18:38:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BC866516B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bugs.launchpad.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJKlh-0004hU-2q for qemu-devel@archiver.kernel.org; Mon, 08 Mar 2021 13:38:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJJn9-0001eS-9E for qemu-devel@nongnu.org; Mon, 08 Mar 2021 12:35:40 -0500 Received: from indium.canonical.com ([91.189.90.7]:36398) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJJn2-00084m-Sc for qemu-devel@nongnu.org; Mon, 08 Mar 2021 12:35:38 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.86_2 #2 (Debian)) id 1lJJn0-0008Ad-7h for ; Mon, 08 Mar 2021 17:35:30 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 393902E804C for ; Mon, 8 Mar 2021 17:35:30 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Mon, 08 Mar 2021 17:28:04 -0000 From: Keith Packard <1915925@bugs.launchpad.net> To: qemu-devel@nongnu.org X-Launchpad-Notification-Type: bug X-Launchpad-Bug: product=qemu; status=Confirmed; importance=Undecided; assignee=alex.bennee@linaro.org; X-Launchpad-Bug-Tags: semihosting testcase X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: ajbennee inver7 keithp pmaydell X-Launchpad-Bug-Reporter: iNvEr7 (inver7) X-Launchpad-Bug-Modifier: Keith Packard (keithp) References: <161356438332.24036.4652954745285513495.malonedeb@chaenomeles.canonical.com> Message-ID: <87czw9ftcr.fsf@keithp.com> Subject: [Bug 1915925] Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml X-Launchpad-Message-For: qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="f41ce4c616a9df6b2066606b5a16a036a6d2f6bb"; Instance="production" X-Launchpad-Hash: a26af3593535dee33c5dd4028fa0a0998ae03f16 Received-SPF: none client-ip=91.189.90.7; envelope-from=bounces@canonical.com; helo=indium.canonical.com X-Spam_score_int: -65 X-Spam_score: -6.6 X-Spam_bar: ------ X-Spam_report: (-6.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bug 1915925 <1915925@bugs.launchpad.net> Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20210308172804.HruVpmtAfCJMKg0A7gE22pg-ny1hvoZwGUUxgpTNn48@z> Alistair Francis writes: > I have started on the effort, but I have not finished yet. Adding > riscv_cpu_is_32bit() was the first step there and I have some more > patches locally but I don't have anything working yet. That's awesome. I think waiting until we see what APIs you're developing for detecting and operating in 32-bit mode on a 64-bit capable processor seems like a good idea for now. -- = -keith -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1915925 Title: ARM semihosting HEAPINFO results wrote to wrong address Status in QEMU: Confirmed Bug description: This affects latest development branch of QEMU. According to the ARM spec of the HEAPINFO semihosting call: https://developer.arm.com/documentation/100863/0300/Semihosting- operations/SYS-HEAPINFO--0x16-?lang=3Den > the PARAMETER REGISTER contains the address of a pointer to a four- field data block. However, QEMU treated the PARAMETER REGISTER as pointing to a four- field data block directly. Here is a simple program that can demonstrate this problem: https://github.com/iNvEr7/qemu-learn/tree/newlib-bug/semihosting- newlib This code links with newlib with semihosting mode, which will call the HEAPINFO SVC during crt0 routine. When running in QEMU (make run), it may crash the program either because of invalid write or memory curruption, depending on the compiled program structure. Also refer to my discussion with newlib folks: https://sourceware.org/pipermail/newlib/2021/018260.html To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1915925/+subscriptions