From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F92C47095 for ; Tue, 6 Oct 2020 06:33:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 54A2B206DD for ; Tue, 6 Oct 2020 06:33:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bGyeZC/h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 54A2B206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPgX3-0000Du-ND for qemu-devel@archiver.kernel.org; Tue, 06 Oct 2020 02:33:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPgU5-0007JQ-TN for qemu-devel@nongnu.org; Tue, 06 Oct 2020 02:30:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:46500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kPgU3-0002qU-Nd for qemu-devel@nongnu.org; Tue, 06 Oct 2020 02:30:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601965798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yAAcD8QTs6gAVS4Fz2gGOg2O+E0hH31+5HO2j95XcVE=; b=bGyeZC/hI6vB9swosFfQYqy8exOIQh8DIuvp+skpA5xTOdrY96WQIwjK68iKPcu221IQEl jwKWxOORrrznkweUdvR8zXvxsJE/Tj7NR3/F/n3ajsb7+S+8hFmirVtEhs5d1igY3/ysPI v4ms9MwfMosW/6zjN2Rjf4x3pGmEwDw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-1eFob-EGMau_3uTD9wjFbg-1; Tue, 06 Oct 2020 02:29:55 -0400 X-MC-Unique: 1eFob-EGMau_3uTD9wjFbg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 255A01015C94; Tue, 6 Oct 2020 06:29:54 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-182.ams2.redhat.com [10.36.112.182]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 663F919C4F; Tue, 6 Oct 2020 06:29:50 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C3B5911329C1; Tue, 6 Oct 2020 08:29:48 +0200 (CEST) From: Markus Armbruster To: Kevin Wolf Subject: Re: [PATCH v8 00/14] monitor: Optionally run handlers in coroutines References: <20201005155855.256490-1-kwolf@redhat.com> Date: Tue, 06 Oct 2020 08:29:48 +0200 In-Reply-To: <20201005155855.256490-1-kwolf@redhat.com> (Kevin Wolf's message of "Mon, 5 Oct 2020 17:58:41 +0200") Message-ID: <87d01v3m03.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=63.128.21.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/06 01:55:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.733, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcandre.lureau@gmail.com, stefanha@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Kevin Wolf writes: > Some QMP command handlers can block the main loop for a relatively long > time, for example because they perform some I/O. This is quite nasty. > Allowing such handlers to run in a coroutine where they can yield (and > therefore release the BQL) while waiting for an event such as I/O > completion solves the problem. > > This series adds the infrastructure to allow this and switches > block_resize to run in a coroutine as a first example. > > This is an alternative solution to Marc-Andr=C3=A9's "monitor: add > asynchronous command type" series. PATCH 01-10: Reviewed-by: Markus Armbruster PATCH 11-14 are for Stefan to review. I can take this through my tree once that's done. Marc-Andr=C3=A9, I figure rebasing your "[PATCH] console: make QMP screendu= mp use coroutine" on top of this is now low risk. No rush, of course.