From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A1DC10F14 for ; Thu, 10 Oct 2019 14:03:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB48B206A1 for ; Thu, 10 Oct 2019 14:03:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB48B206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIZ2Q-0003By-GJ for qemu-devel@archiver.kernel.org; Thu, 10 Oct 2019 10:03:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47682) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIZ11-0002HD-3l for qemu-devel@nongnu.org; Thu, 10 Oct 2019 10:02:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIZ10-0006Aa-0n for qemu-devel@nongnu.org; Thu, 10 Oct 2019 10:02:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38664) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIZ0z-0006AD-RL for qemu-devel@nongnu.org; Thu, 10 Oct 2019 10:02:01 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A5CBA10DCC95 for ; Thu, 10 Oct 2019 14:02:00 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.118.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA82610018FF; Thu, 10 Oct 2019 14:01:56 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5DBBE11384A8; Thu, 10 Oct 2019 16:01:46 +0200 (CEST) From: Markus Armbruster To: Peter Krempa Subject: Re: [PATCH v3 0/3] qapi: Add detection for the 'savevm' fix for blockdev References: Date: Thu, 10 Oct 2019 16:01:46 +0200 In-Reply-To: (Peter Krempa's message of "Thu, 10 Oct 2019 13:05:21 +0200") Message-ID: <87d0f4og1h.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Thu, 10 Oct 2019 14:02:00 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" I have two simple question on PATCH 2, two straightforward refactorings to reduce code duplication, and one commit message tweak. Answer my questions, and then we can decide whether we want a respin or touch-ups in my tree. Thanks!