From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B65BBC3A5A0 for ; Mon, 19 Aug 2019 13:51:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88C042082C for ; Mon, 19 Aug 2019 13:51:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88C042082C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzi4N-0006KQ-Oa for qemu-devel@archiver.kernel.org; Mon, 19 Aug 2019 09:51:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58917) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzi3d-0005sS-UD for qemu-devel@nongnu.org; Mon, 19 Aug 2019 09:50:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzi3c-0005SF-T2 for qemu-devel@nongnu.org; Mon, 19 Aug 2019 09:50:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55304) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hzi3c-0005S5-MB for qemu-devel@nongnu.org; Mon, 19 Aug 2019 09:50:48 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B7BCE3001AB7; Mon, 19 Aug 2019 13:50:47 +0000 (UTC) Received: from redhat.com (unknown [10.36.118.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 33D8A857BC; Mon, 19 Aug 2019 13:50:47 +0000 (UTC) From: Juan Quintela To: Wei Yang In-Reply-To: <20190819032804.8579-1-richardw.yang@linux.intel.com> (Wei Yang's message of "Mon, 19 Aug 2019 11:28:04 +0800") References: <20190819032804.8579-1-richardw.yang@linux.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Mon, 19 Aug 2019 15:50:44 +0200 Message-ID: <87d0h12rij.fsf@trasno.org> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Mon, 19 Aug 2019 13:50:47 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2] migration: cleanup check on ops in savevm.handlers iterations X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: qemu-devel@nongnu.org, dgilbert@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Wei Yang wrote: > During migration, there are several places to iterate on > savevm.handlers. And on each iteration, we need to check its ops and > related callbacks before invoke it. > > Generally, ops is the first element to check, and it is only necessary > to check it once. > > This patch clean all the related part in savevm.c to check ops only once > in those iterations. > > Signed-off-by: Wei Yang Reviewed-by: Juan Quintela Nice cleanup.