From: Markus Armbruster <armbru@redhat.com>
To: Jonah Palmer <jonah.palmer@oracle.com>
Cc: mst@redhat.com, qemu_oss@crudebyte.com, qemu-devel@nongnu.org,
kraxel@redhat.com, si-wei.liu@oracle.com,
joao.m.martins@oracle.com, eblake@redhat.com,
qemu-block@nongnu.org, david@redhat.com, arei.gonglei@huawei.com,
marcandre.lureau@redhat.com, lvivier@redhat.com,
thuth@redhat.com, michael.roth@amd.com, groug@kaod.org,
dgilbert@redhat.com, eric.auger@redhat.com, stefanha@redhat.com,
boris.ostrovsky@oracle.com, kwolf@redhat.com,
mathieu.poirier@linaro.org, raphael.norwitz@nutanix.com,
pbonzini@redhat.com
Subject: Re: [PATCH v11 3/8] qmp: add QMP command x-query-virtio
Date: Thu, 10 Feb 2022 17:04:13 +0100 [thread overview]
Message-ID: <87ee4abtdu.fsf@pond.sub.org> (raw)
In-Reply-To: <1642678168-20447-4-git-send-email-jonah.palmer@oracle.com> (Jonah Palmer's message of "Thu, 20 Jan 2022 06:29:23 -0500")
Jonah Palmer <jonah.palmer@oracle.com> writes:
> From: Laurent Vivier <lvivier@redhat.com>
>
> This new command lists all the instances of VirtIODevices with
> their canonical QOM path and name.
>
> [Jonah: @virtio_list duplicates information that already exists in
> the QOM composition tree. However, extracting necessary information
> from this tree seems to be a bit convoluted.
>
> Instead, we still create our own list of realized virtio devices
> but use @qmp_qom_get with the device's canonical QOM path to confirm
> that the device exists and is realized. If the device exists but
> is actually not realized, then we remove it from our list (for
> synchronicity to the QOM composition tree).
>
> Also, the QMP command @x-query-virtio is redundant as @qom-list
> and @qom-get are sufficient to search '/machine/' for realized
> virtio devices. However, @x-query-virtio is much more convenient
> in listing realized virtio devices.]
Thanks for explaining this. Whether the convenience is worth the extra
code is for the virtio maintainer to decide.
>
> Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2022-02-10 19:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 11:29 [PATCH v11 0/8] hmp,qmp: Add commands to introspect virtio devices Jonah Palmer
2022-01-20 11:29 ` [PATCH v11 1/8] virtio: drop name parameter for virtio_init() Jonah Palmer
2022-01-20 11:29 ` [PATCH v11 2/8] virtio: add vhost support for virtio devices Jonah Palmer
2022-01-20 11:29 ` [PATCH v11 3/8] qmp: add QMP command x-query-virtio Jonah Palmer
2022-02-10 16:04 ` Markus Armbruster [this message]
2022-01-20 11:29 ` [PATCH v11 4/8] qmp: add QMP command x-query-virtio-status Jonah Palmer
2022-02-10 16:05 ` Markus Armbruster
2022-01-20 11:29 ` [PATCH v11 5/8] qmp: decode feature & status bits in virtio-status Jonah Palmer
2022-01-20 11:29 ` [PATCH v11 6/8] qmp: add QMP commands for virtio/vhost queue-status Jonah Palmer
2022-02-11 12:05 ` Markus Armbruster
2022-01-20 11:29 ` [PATCH v11 7/8] qmp: add QMP command x-query-virtio-queue-element Jonah Palmer
2022-02-11 12:08 ` Markus Armbruster
2022-01-20 11:29 ` [PATCH v11 8/8] hmp: add virtio commands Jonah Palmer
2022-02-06 9:39 ` [PATCH v11 0/8] hmp,qmp: Add commands to introspect virtio devices Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee4abtdu.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eric.auger@redhat.com \
--cc=groug@kaod.org \
--cc=joao.m.martins@oracle.com \
--cc=jonah.palmer@oracle.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mathieu.poirier@linaro.org \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=raphael.norwitz@nutanix.com \
--cc=si-wei.liu@oracle.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).