From: Markus Armbruster <armbru@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com
Subject: Re: [PATCH 0/6] qapi: Module fixes and cleanups
Date: Wed, 20 Nov 2019 20:40:39 +0100 [thread overview]
Message-ID: <87eey2mj48.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20191120182551.23795-1-armbru@redhat.com> (Markus Armbruster's message of "Wed, 20 Nov 2019 19:25:45 +0100")
Fat-fingered Kevin's e-mail address...
Markus Armbruster <armbru@redhat.com> writes:
> Kevin recently posted a minimally invasive fix for empty QAPI
> modules[*]. This is my attempt at a fix that also addresses the
> design weakness that led to the bug.
>
> Markus Armbruster (6):
> qapi: Tweak "command returns a nice type" check for clarity
> tests/Makefile.include: Fix missing test-qapi-emit-events.[ch]
> qapi: Generate command registration stuff into separate files
> qapi: Proper intermediate representation for modules
> qapi: Fix code generation for empty modules
> qapi: Simplify QAPISchemaModularCVisitor
>
> docs/devel/qapi-code-gen.txt | 19 ++++-
> Makefile | 4 +-
> monitor/misc.c | 7 +-
> qga/main.c | 2 +-
> tests/test-qmp-cmds.c | 1 +
> .gitignore | 1 +
> qapi/Makefile.objs | 1 +
> qga/Makefile.objs | 1 +
> scripts/qapi/commands.py | 17 +++--
> scripts/qapi/events.py | 2 +-
> scripts/qapi/gen.py | 28 ++++----
> scripts/qapi/schema.py | 92 +++++++++++++++---------
> scripts/qapi/types.py | 5 +-
> scripts/qapi/visit.py | 8 +--
> tests/.gitignore | 1 +
> tests/Makefile.include | 9 ++-
> tests/qapi-schema/empty.out | 1 +
> tests/qapi-schema/include-repetition.out | 6 +-
> tests/qapi-schema/qapi-schema-test.out | 24 +++----
> 19 files changed, 144 insertions(+), 85 deletions(-)
next prev parent reply other threads:[~2019-11-20 19:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 18:25 [PATCH 0/6] qapi: Module fixes and cleanups Markus Armbruster
2019-11-20 18:25 ` [PATCH 1/6] qapi: Tweak "command returns a nice type" check for clarity Markus Armbruster
2019-11-20 19:08 ` Eric Blake
2019-11-20 18:25 ` [PATCH 2/6] tests/Makefile.include: Fix missing test-qapi-emit-events.[ch] Markus Armbruster
2019-11-20 19:16 ` Eric Blake
2019-11-20 18:25 ` [PATCH 3/6] qapi: Generate command registration stuff into separate files Markus Armbruster
2019-11-20 19:26 ` Eric Blake
2019-11-27 16:12 ` Markus Armbruster
2019-11-20 18:25 ` [PATCH 4/6] qapi: Proper intermediate representation for modules Markus Armbruster
2019-11-20 20:31 ` Eric Blake
2019-11-20 18:25 ` [PATCH 5/6] qapi: Fix code generation for empty modules Markus Armbruster
2019-11-20 20:35 ` Eric Blake
2019-11-20 18:25 ` [PATCH 6/6] qapi: Simplify QAPISchemaModularCVisitor Markus Armbruster
2019-11-20 20:54 ` Eric Blake
2019-11-20 19:40 ` Markus Armbruster [this message]
2019-11-20 23:58 ` [PATCH 0/6] qapi: Module fixes and cleanups no-reply
2019-11-21 6:27 ` Markus Armbruster
2019-11-29 9:59 ` [PATCH 7/6] Makefile: Make Makefile depend on generated qga files, too Markus Armbruster
2019-12-03 22:33 ` Eric Blake
2019-12-04 6:56 ` Markus Armbruster
2019-12-04 12:58 ` Eric Blake
2019-12-04 13:19 ` Markus Armbruster
2019-12-03 9:01 ` [PATCH 0/6] qapi: Module fixes and cleanups Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eey2mj48.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).