From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17670C7618F for ; Wed, 17 Jul 2019 14:55:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFDC42173E for ; Wed, 17 Jul 2019 14:55:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFDC42173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnlL7-0003st-21 for qemu-devel@archiver.kernel.org; Wed, 17 Jul 2019 10:55:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47967) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnlKm-0002hg-Pd for qemu-devel@nongnu.org; Wed, 17 Jul 2019 10:55:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnlKl-0000Xb-Pl for qemu-devel@nongnu.org; Wed, 17 Jul 2019 10:55:08 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:42910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnlKj-0000VO-6l; Wed, 17 Jul 2019 10:55:05 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x6HEsGSY054452; Wed, 17 Jul 2019 10:54:34 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 2tt5p08jqp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jul 2019 10:54:34 -0400 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.27/8.16.0.27) with SMTP id x6HEsX65055510; Wed, 17 Jul 2019 10:54:33 -0400 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 2tt5p08jq0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jul 2019 10:54:33 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x6HEodJb018144; Wed, 17 Jul 2019 14:54:32 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma03dal.us.ibm.com with ESMTP id 2tq6x7ga8b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Jul 2019 14:54:32 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x6HEsVDx57016782 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Jul 2019 14:54:31 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4A4966A04D; Wed, 17 Jul 2019 14:54:31 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ED2CB6A057; Wed, 17 Jul 2019 14:54:29 +0000 (GMT) Received: from [9.60.89.78] (unknown [9.60.89.78]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 17 Jul 2019 14:54:29 +0000 (GMT) To: Paolo Bonzini , Thomas Huth , Markus Armbruster References: <20190715095545.28545-1-philmd@redhat.com> <20190715095545.28545-2-philmd@redhat.com> <6d69e8ad-d720-ce04-20f2-a03193903078@redhat.com> <20190715125653.6e65d575.cohuck@redhat.com> <20190715130955.4a117388.cohuck@redhat.com> <13fce62f-234c-1b13-595f-5910c066bc4f@redhat.com> <6c39a198-e951-c0bd-1ddc-5d227afe72ff@redhat.com> <87a7dfth4i.fsf@dusky.pond.sub.org> <20190715181206.3cb1db93.cohuck@redhat.com> <799aa0f5-8850-5caa-5103-e1cf3cdb018f@redhat.com> <87h87m2knh.fsf@dusky.pond.sub.org> <50befb09-d381-4362-9cd1-6fb11c96a719@linux.ibm.com> <633cc3f7-eb20-1bfe-03d2-e481be188eb1@redhat.com> From: Collin Walling Message-ID: <87f07cd0-ebbc-3569-9070-5700e47d4af8@linux.ibm.com> Date: Wed, 17 Jul 2019 10:54:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <633cc3f7-eb20-1bfe-03d2-e481be188eb1@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-17_07:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907170174 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.156.1 Subject: Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cornelia Huck , "open list:RISC-V" , Eduardo Habkost , Sagar Karandikar , "Michael S. Tsirkin" , Helge Deller , Palmer Dabbelt , Mark Cave-Ayland , QEMU Developers , Artyom Tarasenko , "open list:S390" , qemu-arm , Alistair Francis , Gerd Hoffmann , qemu-ppc , David Gibson , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Aurelien Jarno , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/17/19 9:52 AM, Paolo Bonzini wrote: > On 17/07/19 14:59, Collin Walling wrote: >> On 7/16/19 11:04 AM, Thomas Huth wrote: >>> On 16/07/2019 15.06, Markus Armbruster wrote: >>>> Paolo Bonzini writes: >>>> >>>>> On 15/07/19 18:12, Cornelia Huck wrote: >>>>>>> Is it INTx vs. MSI vs. MSI-X? >>>>>> >>>>>> I think for s390x we need (INTx || MSI) vs MSI-X... >>>>> >>>>> I think MSI vs MSI-X is just how it's configured, not the actual >>>>> behavior, so it should be irrelevant. >>>> >>>> My best guesses from confusing information, please correct >>>> misunderstandings: >>>> >>>> 1. PCI devices need to support MSI or MSI-X to work with s390x. >>> >>> I think Cornelia mentioned that we might even require MSI-X there ... >>> Collin (being listed as "S390 PCI" maintainer), can you confirm? >> >> MSI-X is mandatory for PCI devices in the s390 architecture. > > How are MSI and MSI-X distinguished? > > Paolo > PCI host plugging will check for the MSI-X capability on the PCI device. If the MSI-X cap is missing, we fail device plugging. We do not check for MSI. Only MSI-X. Specifically, the capability is represented by PCI_CAP_ID_MSIX in pci_regs.h