From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
pkrempa@redhat.com, nshirokovskiy@virtuozzo.com, den@openvz.org
Subject: Re: [PATCH RFC C0/2] support allocation-map for block-dirty-bitmap-merge
Date: Wed, 28 Apr 2021 07:23:32 +0200 [thread overview]
Message-ID: <87h7jrq8x7.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <0b7abd2d-f601-4224-1261-f939623d7687@redhat.com> (John Snow's message of "Tue, 27 Apr 2021 14:24:56 -0400")
John Snow <jsnow@redhat.com> writes:
> On 4/27/21 7:11 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Hi all!
>> It's a simpler alternative for
>> "[PATCH v4 0/5] block: add block-dirty-bitmap-populate job"
>> <20200902181831.2570048-1-eblake@redhat.com>
>> https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg00978.html
>> https://patchew.org/QEMU/20200902181831.2570048-1-eblake@redhat.com/
>> Since we have "coroutine: true" feature for qmp commands, I think,
>> maybe we can merge allocation status to bitmap without bothering with
>> new block-job?
>> It's an RFC:
>> 1. Main question: is it OK as a simple blocking command, even in a
>> coroutine mode. It's a lot simpler, and it can be simply used in a
>> transaction with other bitmap commands.
>>
>
> Hm, possibly... I did not follow the discussion of coroutine QMP
> commands closely to know what the qualifying criteria to use them are.
>
> (Any wisdom for me here, Markus?)
From Kevin's cover letter:
Some QMP command handlers can block the main loop for a relatively
long time, for example because they perform some I/O. This is quite
nasty. Allowing such handlers to run in a coroutine where they can
yield (and therefore release the BQL) while waiting for an event
such as I/O completion solves the problem.
Running in a coroutine is not a replacement for jobs. Monitor commands
continue to run one after the other, even with multiple monitors. All
this does is letting monitor commands yield.
Running in a coroutine is opt-in, because we're scared of command code
misbehaving in coroutine context[*]. To opt-in, add
'coroutine': true
to the command's QAPI schema.
Misbehaving command code should be rare. The trouble is finding it. If
we had a better handle on that, we could make running in a coroutine
opt-out. Watch out for nested event loops. Test thoroughly.
Questions?
[...]
[*] Discussed at some length in patch review:
Message-ID: <874kwnvgad.fsf@dusky.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg05015.html
prev parent reply other threads:[~2021-04-28 5:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 11:11 [PATCH RFC C0/2] support allocation-map for block-dirty-bitmap-merge Vladimir Sementsov-Ogievskiy
2021-04-27 11:11 ` [PATCH 1/2] qapi: block-dirty-bitmap-merge: support allocation maps Vladimir Sementsov-Ogievskiy
2021-04-27 11:59 ` Vladimir Sementsov-Ogievskiy
2021-04-27 11:11 ` [PATCH 2/2] iotests: add allocation-map-to-bitmap Vladimir Sementsov-Ogievskiy
2021-04-27 11:46 ` [PATCH RFC C0/2] support allocation-map for block-dirty-bitmap-merge Vladimir Sementsov-Ogievskiy
2021-04-27 18:24 ` John Snow
2021-04-28 0:49 ` Vladimir Sementsov-Ogievskiy
2021-04-28 5:23 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7jrq8x7.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=nshirokovskiy@virtuozzo.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).