From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F860C32771 for ; Wed, 22 Jan 2020 06:33:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 667292465A for ; Wed, 22 Jan 2020 06:33:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HdskpnNQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 667292465A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iu9a5-0005uB-Fk for qemu-devel@archiver.kernel.org; Wed, 22 Jan 2020 01:33:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34546) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iu9ZM-00058Z-PK for qemu-devel@nongnu.org; Wed, 22 Jan 2020 01:32:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iu9ZL-0000Gg-TE for qemu-devel@nongnu.org; Wed, 22 Jan 2020 01:32:52 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:33369 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iu9ZL-0000GO-QW for qemu-devel@nongnu.org; Wed, 22 Jan 2020 01:32:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579674771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QtQJIajwIeiF+vNoxyUr6Gd1aW7sCrbw05DjemTpC3o=; b=HdskpnNQq63FNCHzBRufn9qgtrNpR3GiChMH7sdA7UcqgrOxQaxz9LY5OsMNakOALCJJi2 Zf6c9BMr9354f+SXfmfF7A/eq1RTFcb/Wrqf3RLrl7Oq7+FNBsvKBBiKfY2orAmOtr3EUa a5sPDDZmwh3b55McovVm5Zeij8kFJXY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-169-a3XkUcSrNZGbXx3pWE913g-1; Wed, 22 Jan 2020 01:32:49 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4200018A8C8A; Wed, 22 Jan 2020 06:32:48 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-131.ams2.redhat.com [10.36.116.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A52460BE0; Wed, 22 Jan 2020 06:32:45 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 0CC161138600; Wed, 22 Jan 2020 07:32:44 +0100 (CET) From: Markus Armbruster To: Kevin Wolf Subject: Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands References: <20200121181122.15941-1-kwolf@redhat.com> <20200121181122.15941-2-kwolf@redhat.com> Date: Wed, 22 Jan 2020 07:32:44 +0100 In-Reply-To: <20200121181122.15941-2-kwolf@redhat.com> (Kevin Wolf's message of "Tue, 21 Jan 2020 19:11:19 +0100") Message-ID: <87lfq0yp9v.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: a3XkUcSrNZGbXx3pWE913g-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanha@redhat.com, marcandre.lureau@gmail.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Kevin Wolf writes: > This patch adds a new 'coroutine' flag to QMP command definitions that > tells the QMP dispatcher that the command handler is safe to be run in a > coroutine. I'm afraid I missed this question in my review of v3: when is a handler *not* safe to be run in a coroutine? > The documentation of the new flag pretends that this flag is already > used as intended, which it isn't yet after this patch. We'll implement > this in another patch in this series. > > Signed-off-by: Kevin Wolf > Reviewed-by: Marc-Andr=C3=A9 Lureau