From: Markus Armbruster <armbru@redhat.com>
To: Fangrui Song <i@maskray.me>
Cc: qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH v2] Fix incorrect integer->float conversions caught by clang -Wimplicit-int-float-conversion
Date: Fri, 22 Nov 2019 09:06:12 +0100 [thread overview]
Message-ID: <87lfs8tjwr.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20191122000045.vz3eq6s6aqkv6l6h@gmail.com> (Fangrui Song's message of "Thu, 21 Nov 2019 16:00:45 -0800")
Fangrui Song <i@maskray.me> writes:
> On 2019-11-21, Eric Blake wrote:
>>On 11/19/19 2:49 PM, Fangrui Song wrote:
>>
>>>>
>>>>Can we simply drop the offending line statement instead?
>>>
>>>Fixed in the new patch.
>>>
>>
>>>>The first val * mul above this range is 0x1p64. Rejecting it is
>>>>correct, because it overflows yint64_t.
>>>
>>>I am not subscribed, so apologize that this email may be off the thread.
>>>
>>>(The binutils mailing list allows a user to download the raw email so I
>>>can still reply to a specific email, but this list does not provide such
>>>feature.)
There's <https://lists.gnu.org/archive/mbox/qemu-devel/>.
>> Actually, it's better to post a v2 patch as a new top-level thread,
>> rather than buried as an attachment to a reply to v1, because our CI
>> tooling doesn't see through the attachment (nor was it easy for me
>> to reply to the v2 patch - I had to open the attachment to paste its
>> text inline below...).
>>
>>More patch submission hints at https://wiki.qemu.org/Contribute/SubmitAPatch
>
> Retitled to [PATCH v2]
Good, such versioning is essential to avoid confusion. Next time, start
a new top-level thread for v2. Our patch submission processing
(automated as well as human) expects that.
I just did it for you: "[PATCH v3 0/2] Fix incorrect integer->float
conversion caught by clang".
Many thanks for your fixes!
prev parent reply other threads:[~2019-11-22 8:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-16 1:07 [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion Fangrui Song
2019-11-19 15:14 ` Markus Armbruster
2019-11-20 11:15 ` Juan Quintela
2019-11-20 17:30 ` Fangrui Song
2019-11-21 12:18 ` Richard Henderson
2019-11-21 14:51 ` Markus Armbruster
2019-11-21 17:11 ` Fangrui Song
2019-11-19 20:49 ` Fangrui Song
2019-11-21 17:38 ` Eric Blake
2019-11-22 0:00 ` [PATCH v2] Fix incorrect integer->float " Fangrui Song
2019-11-22 8:06 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfs8tjwr.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=i@maskray.me \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).