From: "Alex Bennée" <alex.bennee@linaro.org>
To: Beata Michalska <beata.michalska@linaro.org>
Cc: peter.maydell@linaro.org, quintela@redhat.com,
richard.henderson@linaro.org, qemu-devel@nongnu.org,
shameerali.kolothum.thodi@huawei.com, dgilbert@redhat.com,
eric.auger@redhat.com, qemu-arm@nongnu.org, pbonzini@redhat.com
Subject: Re: [PATCH v2 3/4] migration: ram: Switch to ram block writeback
Date: Wed, 06 Nov 2019 14:18:10 +0000 [thread overview]
Message-ID: <87lfsthyvx.fsf@linaro.org> (raw)
In-Reply-To: <20191105234100.22052-4-beata.michalska@linaro.org>
Beata Michalska <beata.michalska@linaro.org> writes:
> Switch to ram block writeback for pmem migration.
>
> Signed-off-by: Beata Michalska <beata.michalska@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> migration/ram.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 5078f94..38070f1 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -33,7 +33,6 @@
> #include "qemu/bitops.h"
> #include "qemu/bitmap.h"
> #include "qemu/main-loop.h"
> -#include "qemu/pmem.h"
> #include "xbzrle.h"
> #include "ram.h"
> #include "migration.h"
> @@ -3981,9 +3980,7 @@ static int ram_load_cleanup(void *opaque)
> RAMBlock *rb;
>
> RAMBLOCK_FOREACH_NOT_IGNORED(rb) {
> - if (ramblock_is_pmem(rb)) {
> - pmem_persist(rb->host, rb->used_length);
> - }
> + qemu_ram_block_writeback(rb);
> }
>
> xbzrle_load_cleanup();
--
Alex Bennée
next prev parent reply other threads:[~2019-11-06 14:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 23:40 [PATCH v2 0/4] target/arm: Support for Data Cache Clean up to PoP Beata Michalska
2019-11-05 23:40 ` [PATCH v2 1/4] tcg: cputlb: Add probe_read Beata Michalska
2019-11-05 23:40 ` [PATCH v2 2/4] Memory: Enable writeback for given memory region Beata Michalska
2019-11-06 12:19 ` Richard Henderson
2019-11-07 14:41 ` Beata Michalska
2019-11-07 16:57 ` Alex Bennée
2019-11-07 16:59 ` Peter Maydell
2019-11-05 23:40 ` [PATCH v2 3/4] migration: ram: Switch to ram block writeback Beata Michalska
2019-11-06 14:18 ` Alex Bennée [this message]
2019-11-05 23:41 ` [PATCH v2 4/4] target/arm: Add support for DC CVAP & DC CVADP ins Beata Michalska
2019-11-06 12:37 ` Richard Henderson
2023-11-28 11:24 ` Philippe Mathieu-Daudé
2023-11-28 11:34 ` Peter Maydell
2023-11-28 11:44 ` Philippe Mathieu-Daudé
2023-11-28 18:07 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfsthyvx.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=beata.michalska@linaro.org \
--cc=dgilbert@redhat.com \
--cc=eric.auger@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=shameerali.kolothum.thodi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).