From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson
Date: Mon, 29 Jul 2019 13:41:54 +0100 [thread overview]
Message-ID: <87lfwhhv1p.fsf@linaro.org> (raw)
In-Reply-To: <20190729082115.GB32718@redhat.com>
Daniel P. Berrangé <berrange@redhat.com> writes:
> On Sat, Jul 27, 2019 at 07:20:15PM +0100, Peter Maydell wrote:
>> On Sat, 27 Jul 2019 at 13:24, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> >
>> > On 27/07/19 09:16, Markus Armbruster wrote:
>> > > We started with a single trace-events. That wasn't good, so we split it
>> > > up into one per directory. That isn't good, so what about splitting it
>> > > up into one per source file? Pass -DTRACE_HEADER='"trace-DIR-FOO.h"
>> > > instead of -DTRACE_HEADER='"trace-DIR.h"' when compiling DIR/FOO.c.
>> >
>> > For Make this would all work great, however not for Meson because it
>> > doesn't allow per-file compile flags.
>>
>> Apologies for randomly parachuting into this email thread, but if
>> Meson doesn't support per-file compile flags then what's the plan
>> for handling the cases where we currently need per-file compile flags ?
>
> I'd suggest we don't actually /need/ per-file compiler flags in most
> cases. eg when we add $foo.o-libs += $(FOO_LIBS) that's not really
> a per-file setting when it gets expanded onto the final linker line.
> Its just a "-lfoo" that gets used for the library as a while.
We do for tests, often to select a specific processor type or feature we
need to build that particular instance of the test.
--
Alex Bennée
next prev parent reply other threads:[~2019-07-29 12:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 16:14 [Qemu-devel] [RFC PATCH v2 0/8] Proof of concept for Meson integration Paolo Bonzini
2019-07-10 16:14 ` [Qemu-devel] [PATCH 1/8] configure: do not include $(...) variables in config-host.mak Paolo Bonzini
2019-07-10 16:14 ` [Qemu-devel] [PATCH 2/8] configure: set $PYTHON to a full path Paolo Bonzini
2019-07-10 16:14 ` [Qemu-devel] [PATCH 3/8] configure: integrate Meson in the build system Paolo Bonzini
2019-07-10 16:14 ` [Qemu-devel] [PATCH 4/8] convert libqemuutil to meson Paolo Bonzini
2019-07-13 14:15 ` Markus Armbruster
2019-07-13 21:26 ` Paolo Bonzini
2019-07-27 7:16 ` Markus Armbruster
2019-07-27 12:23 ` Paolo Bonzini
2019-07-27 18:20 ` Peter Maydell
2019-07-29 7:09 ` Markus Armbruster
2019-07-29 8:51 ` Paolo Bonzini
2019-07-29 9:21 ` Peter Maydell
2019-07-29 9:29 ` Paolo Bonzini
2019-07-29 9:32 ` Peter Maydell
2019-07-29 9:36 ` Paolo Bonzini
2019-07-29 11:12 ` Markus Armbruster
2019-07-29 8:21 ` Daniel P. Berrangé
2019-07-29 9:19 ` Peter Maydell
2019-07-29 12:41 ` Alex Bennée [this message]
2019-07-29 14:08 ` Paolo Bonzini
2019-07-10 16:14 ` [Qemu-devel] [PATCH 5/8] libvhost-user: convert to Meson Paolo Bonzini
2019-07-10 16:14 ` [Qemu-devel] [PATCH 6/8] vhost-user-blk: " Paolo Bonzini
2019-07-10 16:14 ` [Qemu-devel] [PATCH 7/8] vhost-user-scsi: " Paolo Bonzini
2019-07-10 16:14 ` [Qemu-devel] [PATCH 8/8] rdmacm-mux: " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfwhhv1p.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).