From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Eduardo Habkost" <ehabkost@redhat.com>
Subject: Re: [PATCH v7 02/12] accel: Introduce 'query-accels' QMP command
Date: Fri, 21 May 2021 12:00:20 +0200 [thread overview]
Message-ID: <87mtsoieyz.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <87wnrsifbd.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Fri, 21 May 2021 11:52:54 +0200")
Markus Armbruster <armbru@redhat.com> writes:
> The appended incremental patch conditionalizes the enum. It applies on
> top of the series, and passes "make check" for me. Seems to contradict
> "we can't make the enum values conditional".
Neglected to mention that query-accel becomes almost useless in this
version: we need it just to pull enum Accelerator into the QMP
interface, so query-qmp-schema shows it.
It may become a useful command if we add more members to AcceleratorInfo
later.
next prev parent reply other threads:[~2021-05-21 10:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 12:57 [PATCH v7 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels' Philippe Mathieu-Daudé
2021-05-05 12:57 ` [PATCH v7 01/12] MAINTAINERS: Add qtest/arm-cpu-features.c to ARM TCG CPUs section Philippe Mathieu-Daudé
2021-05-05 12:57 ` [PATCH v7 02/12] accel: Introduce 'query-accels' QMP command Philippe Mathieu-Daudé
2021-05-05 19:41 ` Eduardo Habkost
2021-05-21 9:39 ` Philippe Mathieu-Daudé
2021-05-21 9:15 ` Markus Armbruster
2021-05-21 9:52 ` Markus Armbruster
2021-05-21 10:00 ` Markus Armbruster [this message]
2021-05-05 12:57 ` [PATCH v7 03/12] qtest: Add qtest_has_accel() method Philippe Mathieu-Daudé
2021-05-05 12:57 ` [PATCH v7 04/12] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM Philippe Mathieu-Daudé
2021-05-05 12:57 ` [PATCH v7 05/12] qtest/arm-cpu-features: Restrict sve_tests_sve_off_kvm test to KVM Philippe Mathieu-Daudé
2021-05-05 12:58 ` [PATCH v7 06/12] qtest/arm-cpu-features: Remove TCG fallback to KVM specific tests Philippe Mathieu-Daudé
2021-05-05 12:58 ` [PATCH v7 07/12] qtest/arm-cpu-features: Use generic qtest_has_accel() to check for TCG Philippe Mathieu-Daudé
2021-05-05 12:58 ` [PATCH v7 08/12] qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64 Philippe Mathieu-Daudé
2021-05-05 12:58 ` [PATCH v7 09/12] qtest/bios-tables-test: Rename tests not TCG specific Philippe Mathieu-Daudé
2021-05-05 12:58 ` [PATCH v7 10/12] qtest/bios-tables-test: Rename TCG specific tests Philippe Mathieu-Daudé
2021-05-05 12:58 ` [PATCH v7 11/12] qtest/bios-tables-test: Make test build-independent from accelerator Philippe Mathieu-Daudé
2021-05-05 12:58 ` [PATCH v7 12/12] qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore Philippe Mathieu-Daudé
2021-05-05 13:20 ` [PATCH v7 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels' Philippe Mathieu-Daudé
2021-05-05 15:29 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtsoieyz.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).