From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D8D6C433ED for ; Tue, 13 Apr 2021 09:50:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED5BF613B6 for ; Tue, 13 Apr 2021 09:50:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED5BF613B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48734 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWFgK-0004fq-4h for qemu-devel@archiver.kernel.org; Tue, 13 Apr 2021 05:50:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWFfN-0004GB-Lq for qemu-devel@nongnu.org; Tue, 13 Apr 2021 05:49:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47777) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWFfL-0008Rp-5Y for qemu-devel@nongnu.org; Tue, 13 Apr 2021 05:49:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618307342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OGR/Byv26qmkmAdrXQM6ZrFO8+8PGQQAT5SYgJBcl/U=; b=BiIrMEB9sZsfFiGLjW7RPKt1nLaThvW8rMokkGiweEdtIKlqXgt/ddBkJ0y81/4YcjBpJs xM3LdIE0EBhePg/GKyzd9zfXCMvfHa/Hrc61lvoIc4UnCuQz6q4VZa/MqadA3p261/GW4W mZzVo4FjcYHsN4gDbOcq3BJF5o1dGgQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-T6pmKl9XO-ihhuF3qTqCJg-1; Tue, 13 Apr 2021 05:49:00 -0400 X-MC-Unique: T6pmKl9XO-ihhuF3qTqCJg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DFA8F1883522 for ; Tue, 13 Apr 2021 09:48:59 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 56B7C690FA; Tue, 13 Apr 2021 09:48:56 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 9BE60113525D; Tue, 13 Apr 2021 11:48:54 +0200 (CEST) From: Markus Armbruster To: David Hildenbrand Subject: Re: [PATCH v2 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it References: <20210312173547.1283477-1-pbonzini@redhat.com> <20210312173547.1283477-3-pbonzini@redhat.com> <87im4q23v2.fsf@dusky.pond.sub.org> <07c08cc3-f3ca-6f7a-e5f7-d2d3ee8de79e@redhat.com> Date: Tue, 13 Apr 2021 11:48:54 +0200 In-Reply-To: <07c08cc3-f3ca-6f7a-e5f7-d2d3ee8de79e@redhat.com> (David Hildenbrand's message of "Tue, 13 Apr 2021 10:13:39 +0200") Message-ID: <87mtu2wm49.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, Paolo Bonzini , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" David Hildenbrand writes: > On 13.04.21 06:41, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> On 12.03.21 18:35, Paolo Bonzini wrote: >>>> Emulators are currently using OptsVisitor (via user_creatable_add_opts) >>>> to parse the -object command line option. This has one extra feature, >>>> compared to keyval, which is automatic conversion of integers to lists >>>> as well as support for lists as repeated options: >>>> -object >>>> memory-backend-ram,id=pc.ram,size=1048576000,host-nodes=0,policy=bind >>>> So we cannot replace OptsVisitor with keyval right now. Still, this >>>> patch moves the user_creatable_add_opts logic to vl.c since it is >>>> not needed anywhere else, and makes it go through user_creatable_add_qapi. >>>> In order to minimize code changes, the predicate still takes a >>>> string. >>>> This can be changed later to use the ObjectType QAPI enum directly. >>>> >>> >>> Rebasing my "noreserve"[1] series on this, I get weird errors from >>> QEMU when specifying the new "reserve=off" option for a >>> memory-backend-ram: >>> >>> "Invalid parameter 'reserve'" >>> >>> And it looks like this is the case for any new properties. Poking >>> around, I fail to find what's causing this -- or how to unlock new >>> properties. What is the magic toggle to make it work? >>> >>> Thanks! >>> >>> [1] https://lkml.kernel.org/r/20210319101230.21531-1-david@redhat.com >> Wild guess: you didn't add your new properties in the QAPI schema. >> For a not-so-wild-guess, send us a git-fetch argument for your >> rebased >> series. >> > > Oh, there is qapi/qom.json -- maybe that does the trick. > > (I have mixed feelings about having to specify the same thing twice at > different locations) With reason. We've talked about generating QOM boilerplate from the QAPI schema, but haven't progressed to actual patches. > I'll have a look if that makes it fly.