From: Juan Quintela <quintela@redhat.com>
To: Haibo Xu <haibo.xu@linaro.org>
Cc: peter.maydell@linaro.org, drjones@redhat.com,
richard.henderson@linaro.org, dgilbert@redhat.com,
qemu-devel@nongnu.org, qemu-arm@nongnu.org, philmd@redhat.com
Subject: Re: [RFC PATCH v2 5/5] Enable the MTE support for KVM guest
Date: Thu, 25 Mar 2021 13:40:41 +0100 [thread overview]
Message-ID: <87mturo186.fsf@secure.mitica> (raw)
In-Reply-To: <5ed81ba84e44100798009cee95c3dc2d993602f0.1615972140.git.haibo.xu@linaro.org> (Haibo Xu's message of "Wed, 17 Mar 2021 09:28:24 +0000")
Haibo Xu <haibo.xu@linaro.org> wrote:
> Signed-off-by: Haibo Xu <haibo.xu@linaro.org>
> ---
> hw/arm/virt.c | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 76658b93a3..36cfdb29e9 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -79,6 +79,7 @@
> #include "hw/virtio/virtio-iommu.h"
> #include "hw/char/pl011.h"
> #include "qemu/guest-random.h"
> +#include "migration/misc.h"
>
> #define DEFINE_VIRT_MACHINE_LATEST(major, minor, latest) \
> static void virt_##major##_##minor##_class_init(ObjectClass *oc, \
> @@ -828,6 +829,21 @@ static void virt_powerdown_req(Notifier *n, void *opaque)
> }
> }
>
> +static int virt_precopy_notify(NotifierWithReturn *n, void *data)
> +{
> + PrecopyNotifyData *pnd = data;
> +
> + switch (pnd->reason) {
> + case PRECOPY_NOTIFY_SETUP:
> + precopy_enable_metadata_migration();
> + break;
> + default:
> + break;
> + }
> +
> + return 0;
> +}
> +
> static void create_gpio_keys(char *fdt, DeviceState *pl061_dev,
> uint32_t phandle)
> {
> @@ -1912,9 +1928,9 @@ static void machvirt_init(MachineState *machine)
> }
>
> if (vms->mte && kvm_enabled()) {
> - error_report("mach-virt: KVM does not support providing "
> - "MTE to the guest CPU");
> - exit(1);
> + /* connect migration precopy request */
> + vms->precopy_notifier.notify = virt_precopy_notify;
> + precopy_add_notifier(&vms->precopy_notifier);
> }
>
> create_fdt(vms);
Why are you using a notifier here?
It is not enough for you just esetup at this point a variable somewhere
"foo->mte_enabled = true"
And create a function that just does:
bool is_mte_enabled(vode)
{
return foo->mte_enabled;
}
And just check that everywhere?
Later, Juan.
prev parent reply other threads:[~2021-03-25 12:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 9:28 [RFC PATCH v2 0/5] target/arm: Add MTE support to KVM guest Haibo Xu
2021-03-17 9:28 ` [RFC PATCH v2 1/5] Update Linux headers with new MTE support Haibo Xu
2021-03-17 9:28 ` [RFC PATCH v2 2/5] Add basic MTE support to KVM guest Haibo Xu
2021-03-17 9:28 ` [RFC PATCH v2 3/5] Add APIs to get/set MTE tags Haibo Xu
2021-03-25 12:18 ` Juan Quintela
2021-04-01 13:12 ` Haibo Xu
2021-03-17 9:28 ` [RFC PATCH v2 4/5] Add migration support for KVM guest with MTE Haibo Xu
2021-03-17 20:11 ` Dr. David Alan Gilbert
2021-03-18 6:38 ` Haibo Xu
2021-03-25 19:37 ` Dr. David Alan Gilbert
2021-04-01 13:33 ` Haibo Xu
2021-03-25 15:37 ` Juan Quintela
2021-04-01 13:26 ` Haibo Xu
2021-03-17 9:28 ` [RFC PATCH v2 5/5] Enable the MTE support for KVM guest Haibo Xu
2021-03-25 12:40 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mturo186.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=haibo.xu@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).