From: Markus Armbruster <armbru@redhat.com>
To: "Longpeng (Mike,
Cloud Infrastructure Service Product Dept.)"
<longpeng2@huawei.com>
Cc: chenjiashang@huawei.com,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Peter Xu" <peterx@redhat.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
pbonzini@redhat.com, marcandre.lureau@redhat.com
Subject: Re: A bug of Monitor Chardev ?
Date: Tue, 08 Jun 2021 16:07:30 +0200 [thread overview]
Message-ID: <87o8cgxxel.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <cd197959-7da0-ee50-1e65-e6b2e7107a86@huawei.com> (Longpeng's message of "Mon, 17 May 2021 14:56:39 +0800")
"Longpeng (Mike, Cloud Infrastructure Service Product Dept.)"
<longpeng2@huawei.com> writes:
> We find a race during QEMU starting, which would case the QEMU process coredump.
>
> <main loop> | <MON iothread>
> |
> [1] create MON chardev |
> qemu_create_early_backends |
> chardev_init_func |
> |
> [2] create MON iothread |
> qemu_create_late_backends |
> mon_init_func |
> aio_bh_schedule-----------------------> monitor_qmp_setup_handlers_bh
> [3] enter main loog | tcp_chr_update_read_handler
> (* A client come in, e.g. Libvirt *) | update_ioc_handlers
> tcp_chr_new_client |
> update_ioc_handlers |
> |
> [4] create new hup_source |
> s->hup_source = *PTR1* |
> g_source_attach(s->hup_source)|
> | [5] remove_hup_source(*PTR1*)
> | (create new hup_source)
> | s->hup_source = *PTR2*
> [6] g_source_attach_unlocked |
> *PTR1* is freed by [5] |
>
> Do you have any suggestion to fix this bug ? Thanks!
Do we? We talked, but I'm not sure we reached a conclusion.
next prev parent reply other threads:[~2021-06-08 14:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 6:56 A bug of Monitor Chardev ? Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-05-19 16:17 ` Marc-André Lureau
2021-05-19 16:40 ` Daniel P. Berrangé
2021-05-21 7:25 ` Markus Armbruster
2021-05-21 14:43 ` Peter Xu
2021-05-21 16:33 ` Daniel P. Berrangé
2021-05-21 16:56 ` Daniel P. Berrangé
2021-05-21 16:59 ` Marc-André Lureau
2021-05-21 17:07 ` Daniel P. Berrangé
2021-05-21 17:14 ` Peter Xu
2021-05-25 6:53 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-05-21 17:09 ` Peter Xu
2021-05-21 17:15 ` Daniel P. Berrangé
2021-06-08 14:07 ` Markus Armbruster [this message]
2021-06-08 15:37 ` Daniel P. Berrangé
2021-06-09 0:20 ` Longpeng (Mike, Cloud Infrastructure Service Product Dept.)
2021-06-09 10:13 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8cgxxel.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=berrange@redhat.com \
--cc=chenjiashang@huawei.com \
--cc=longpeng2@huawei.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).