From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F6B3C433E0 for ; Wed, 5 Aug 2020 07:37:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D9442245C for ; Wed, 5 Aug 2020 07:37:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="THSY677h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D9442245C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3Dzl-0001vy-9T for qemu-devel@archiver.kernel.org; Wed, 05 Aug 2020 03:37:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3Dz6-0001RN-8f for qemu-devel@nongnu.org; Wed, 05 Aug 2020 03:37:12 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:27467 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k3Dz4-0000Xw-Ot for qemu-devel@nongnu.org; Wed, 05 Aug 2020 03:37:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596613030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1+zvYP83G0BJyWpmIPHKodcpJG9ubtC/2fz8OKMx85U=; b=THSY677hCdkw9wDwZgsm/YpZANurZg8MZ4/XXhKjZQO6HPWU9SEThEfmcI1xlG4oBmX6Nu i3FQZQQk06aKwtPUy+Bsd6BrAnGGyn+uPlvhXT7yU8NsI4q5GuK8FuHDfNnf5XmOuRFAXi e591r+uLXz3chxb2wn6qUqSSsHFLlew= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-459-nBkLojHsNNG6BkOyncOO1g-1; Wed, 05 Aug 2020 03:37:06 -0400 X-MC-Unique: nBkLojHsNNG6BkOyncOO1g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5234F106B244; Wed, 5 Aug 2020 07:37:05 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-143.ams2.redhat.com [10.36.112.143]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7AD410027A6; Wed, 5 Aug 2020 07:36:55 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4EDD51141D60; Wed, 5 Aug 2020 09:36:54 +0200 (CEST) From: Markus Armbruster To: John Snow Subject: Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline) References: <20200729185024.121766-1-abologna@redhat.com> <87ime52wxd.fsf@dusky.pond.sub.org> <20200730093732.GB3477223@redhat.com> <87k0ylz0ep.fsf@dusky.pond.sub.org> <20200730132446.GL3477223@redhat.com> <875za33ku1.fsf@dusky.pond.sub.org> <20200731150738.GB3660103@redhat.com> <2cf1a431-9d2c-8ad6-446e-f10b36219764@redhat.com> <87d048i1m2.fsf@dusky.pond.sub.org> <83bbe0b0-c5e0-e3b7-5ba1-5946098370d5@redhat.com> <87ft94klyl.fsf@dusky.pond.sub.org> <490a0786-73f3-411e-4dfe-8c2ae90de251@redhat.com> <87y2mvhg3k.fsf@dusky.pond.sub.org> <87k0yeg7mc.fsf@dusky.pond.sub.org> <6e5df5fc-94f8-ee8e-0c14-f56135de25e4@redhat.com> Date: Wed, 05 Aug 2020 09:36:54 +0200 In-Reply-To: <6e5df5fc-94f8-ee8e-0c14-f56135de25e4@redhat.com> (John Snow's message of "Tue, 4 Aug 2020 14:24:22 -0400") Message-ID: <87o8np5ysp.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=207.211.31.120; envelope-from=armbru@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/05 01:46:02 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9?=" , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , Jason Wang , Juan Quintela , qemu-devel@nongnu.org, Yuval Shaia , Gerd Hoffmann , Andrea Bolognani , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Michael Roth , "Dr. David Alan Gilbert" , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > On 8/4/20 4:03 AM, Markus Armbruster wrote: >> The pain of tweaking the parser is likely dwarved several times over by >> the pain of the flag day. > > You mention this often; I wonder if I misunderstand the critique, > because the pain of a "flag day" for a new file format seems > negligible to me. > > I don't think we edit these .json files very often. Generally, we add > a new command when we need one. The edits are usually one or two lines > plus docstrings. > > If anyone has patches in-flight, I genuinely doubt it will take more > than a few minutes to rewrite for the new file format. > > No? You describe the the flag day's one-time pain. There's also the longer term pain of having to work around git-blame unable to see beyond the flag day. I'm not claiming the pain is prohibitive (if I thought it was, I would've tried to strange this thread in its crib), I am claiming it'll be much more painful (read: expensive) than a parser tweak.