From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert \(git\)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, peterx@redhat.com, LMa@suse.com
Subject: Re: [PATCH] migration: Rate limit inside host pages
Date: Thu, 05 Dec 2019 14:54:31 +0100 [thread overview]
Message-ID: <87o8wmkhd4.fsf@trasno.org> (raw)
In-Reply-To: <20191205102918.63294-1-dgilbert@redhat.com> (David Alan Gilbert's message of "Thu, 5 Dec 2019 10:29:18 +0000")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> When using hugepages, rate limiting is necessary within each huge
> page, since a 1G huge page can take a significant time to send, so
> you end up with bursty behaviour.
>
> Fixes: 4c011c37ecb3 ("postcopy: Send whole huge pages")
> Reported-by: Lin Ma <LMa@suse.com>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
Reviewed-by: Juan Quintela <quintela@redhat.com>
I can agree that rate limit needs to be done for huge pages.
> diff --git a/migration/ram.c b/migration/ram.c
> index a4ae3b3120..a9177c6a24 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -2616,6 +2616,8 @@ static int ram_save_host_page(RAMState *rs, PageSearchStatus *pss,
>
> pages += tmppages;
> pss->page++;
> + /* Allow rate limiting to happen in the middle of huge pages */
> + migration_rate_limit();
> } while ((pss->page & (pagesize_bits - 1)) &&
> offset_in_ramblock(pss->block, pss->page << TARGET_PAGE_BITS));
>
But is doing the rate limit for each page, no? Even when not using huge
pages.
Not that it should be a big issue (performance wise).
Have you done any meassuremnet?
Later, Juan.
next prev parent reply other threads:[~2019-12-05 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 10:29 [PATCH] migration: Rate limit inside host pages Dr. David Alan Gilbert (git)
2019-12-05 13:54 ` Juan Quintela [this message]
2019-12-05 14:30 ` Dr. David Alan Gilbert
2019-12-05 13:55 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8wmkhd4.fsf@trasno.org \
--to=quintela@redhat.com \
--cc=LMa@suse.com \
--cc=dgilbert@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).