From: "Alex Bennée" <alex.bennee@linaro.org>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: fam@euphon.net, ehabkost@redhat.com, jsnow@redhat.com,
qemu-devel@nongnu.org, crosa@redhat.com, philmd@redhat.com
Subject: Re: [PATCH 3/4] python/qemu: accel: Strengthen kvm_available() checks
Date: Tue, 03 Dec 2019 16:58:31 +0000 [thread overview]
Message-ID: <87r21l9wi0.fsf@linaro.org> (raw)
In-Reply-To: <20191115180829.10275-4-wainersm@redhat.com>
Wainer dos Santos Moschetta <wainersm@redhat.com> writes:
> Currently kvm_available() checks for the presence of kvm module
> and, if target and host arches don't mismatch. This patch adds
> an 3rd checking: if QEMU binary was compiled with kvm
> support.
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> python/qemu/accel.py | 27 +++++++++++++++++++++------
> 1 file changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/python/qemu/accel.py b/python/qemu/accel.py
> index a63ff980a9..1978fbee4e 100644
> --- a/python/qemu/accel.py
> +++ b/python/qemu/accel.py
> @@ -48,9 +48,24 @@ def list_accel(qemu_bin):
> # Skip the first line which is the header.
> return [l.strip() for l in lines[1:] if l]
>
> -def kvm_available(target_arch=None):
> - host_arch = os.uname()[4]
> - if target_arch and target_arch != host_arch:
> - if target_arch != ADDITIONAL_ARCHES.get(host_arch):
> - return False
> - return os.access("/dev/kvm", os.R_OK | os.W_OK)
> +def kvm_available(target_arch=None, qemu_bin=None):
> + """
> + Check if KVM is available using the following heuristic:
> + - Kernel module is present in the host;
> + - Target and host arches don't mismatch;
> + - KVM is enabled in the QEMU binary.
> +
> + @param target_arch (str): target architecture
> + @param qemu_bin (str): path to the QEMU binary
> + @return True if kvm is available, otherwise False.
> + """
> + if not os.access("/dev/kvm", os.R_OK | os.W_OK):
> + return False
> + if target_arch:
> + host_arch = os.uname()[4]
> + if target_arch != host_arch:
> + if target_arch != ADDITIONAL_ARCHES.get(host_arch):
> + return False
> + if qemu_bin and "kvm" not in list_accel(qemu_bin):
> + return False
> + return True
--
Alex Bennée
next prev parent reply other threads:[~2019-12-03 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 18:08 [PATCH 0/4] python/qemu: New accel module and improvements Wainer dos Santos Moschetta
2019-11-15 18:08 ` [PATCH 1/4] python/qemu: Move kvm_available() to its own module Wainer dos Santos Moschetta
2019-12-03 16:21 ` Alex Bennée
2019-11-15 18:08 ` [PATCH 2/4] python/qemu: accel: Add list_accel() method Wainer dos Santos Moschetta
2019-12-03 16:57 ` Alex Bennée
2019-11-15 18:08 ` [PATCH 3/4] python/qemu: accel: Strengthen kvm_available() checks Wainer dos Santos Moschetta
2019-12-03 16:58 ` Alex Bennée [this message]
2019-11-15 18:08 ` [PATCH 4/4] python/qemu: accel: Add tcg_available() method Wainer dos Santos Moschetta
2019-12-03 17:00 ` Alex Bennée
2019-12-03 17:25 ` [PATCH 0/4] python/qemu: New accel module and improvements Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r21l9wi0.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).