From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWk2J-0005oJ-H0 for qemu-devel@nongnu.org; Fri, 19 Feb 2016 07:19:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWk2G-00086T-H6 for qemu-devel@nongnu.org; Fri, 19 Feb 2016 07:19:51 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:34522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWk2G-00086P-44 for qemu-devel@nongnu.org; Fri, 19 Feb 2016 07:19:48 -0500 Received: by mail-wm0-x22d.google.com with SMTP id b205so65780602wmb.1 for ; Fri, 19 Feb 2016 04:19:48 -0800 (PST) References: <1454059965-23402-1-git-send-email-a.rigo@virtualopensystems.com> <87twl4diwv.fsf@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: Date: Fri, 19 Feb 2016 12:19:45 +0000 Message-ID: <87r3g8dh9a.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC v7 00/16] Slow-path for atomic instruction translation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: alvise rigo Cc: MTTCG Devel , Claudio Fontana , QEMU Developers , Paolo Bonzini , Jani Kokkonen , VirtualOpenSystems Technical Team , Richard Henderson alvise rigo writes: > On Fri, Feb 19, 2016 at 12:44 PM, Alex Bennée wrote: >> >> Alvise Rigo writes: >> >>> This is the seventh iteration of the patch series which applies to the >>> upstream branch of QEMU (v2.5.0-rc4). >>> >>> Changes versus previous versions are at the bottom of this cover letter. >>> >>> The code is also available at following repository: >>> https://git.virtualopensystems.com/dev/qemu-mt.git >>> branch: >>> slowpath-for-atomic-v7-no-mttcg >> >> OK I'm done on this review pass. I think generally we are in pretty good >> shape although I await to see what extra needs to be done for the MTTCG >> case. > > Hi Alex, > > Thank you for this review. Regarding the extra needs and integration > with the MTTCG code, I've made available at this address [1] a working > branch with the two patch series merged together. The branch boots > fine Linux on both aarch64 and arm architectures. There is still that > known issue with virtio, that Fred should fix soon. Let me know your > first impressions. Does the virtio problem it go away if you drop the top patch (as per my last email)? > > [1] https://git.virtualopensystems.com/dev/qemu-mt.git (branch > "merging-slowpath-v7-mttcg-v8-wip") Thanks I'll have a look next week. > > Thank you, > alvise > >> >> We are coming up to soft-freeze on 1/3/16 and it would be nice to get >> this merged by then. As it is a fairly major chunk of work it would need >> to get the initial commit by that date. >> >> However before we can get to that stage we need some review from the >> maintainers. For your next version can you please: >> >> - Drop the RFC tag, I think we have had enough comment ;-) >> - Make sure you CC the TCG maintainers (Paolo, Peter C and Richard Henderson) >> - Also CC the ARM maintainers (Peter M) >> - Be ready for a fast turnaround >> >> Paolo/Richard, >> >> Do you have any comments on this iteration? >> >> -- >> Alex Bennée -- Alex Bennée