QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Alyssa Ross <hi@alyssa.is>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Subject: vhost-user protocol feature negotiation
Date: Wed, 05 Aug 2020 15:13:06 +0000
Message-ID: <87sgd1ktx9.fsf@alyssa.is> (raw)

Quoting from the definition of VHOST_USER_SET_PROTOCOL_FEATURES in

>   Only legal if feature bit ``VHOST_USER_F_PROTOCOL_FEATURES`` is present in
> .. Note::
>    Slave that reported ``VHOST_USER_F_PROTOCOL_FEATURES`` must support
>    this message even before ``VHOST_USER_SET_FEATURES`` was called.

To me, this could mean either of two things:

(1) If VHOST_USER_F_PROTOCOL_FEATURES hasn't been set, upon receiving
    VHOST_USER_SET_PROTOCOL_FEATURES, a backend should enable the
    protocol features immediately.

(2) If VHOST_USER_F_PROTOCOL_FEATURES hasn't been set, upon receiving
    VHOST_USER_SET_PROTOCOL_FEATURES, a backend should store those
    feature bits, but not actually consider them to be enabled until
    after VHOST_USER_SET_FEATURES has been received (presumably

The reason I bring this up is that QEMU appears to interpret it as (1),
while the vhost-user-net backend in Intel's cloud-hypervisor[1]
interprets it as (2).  So I'm looking for a clarification.

[1]: https://github.com/cloud-hypervisor/cloud-hypervisor

Thanks in advance.

             reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05 15:13 Alyssa Ross [this message]
2020-08-05 22:26 ` Michael S. Tsirkin
2020-08-06  8:59   ` Alyssa Ross
2020-08-06  9:49     ` Michael S. Tsirkin
2020-08-06 11:24       ` Alyssa Ross
2020-08-06 12:35         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgd1ktx9.fsf@alyssa.is \
    --to=hi@alyssa.is \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git
	git clone --mirror https://lore.kernel.org/qemu-devel/2 qemu-devel/git/2.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git