From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Xiaohui Li <xiaohli@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery
Date: Fri, 06 Sep 2019 15:35:33 +0200 [thread overview]
Message-ID: <87sgp9k0nu.fsf@trasno.org> (raw)
In-Reply-To: <20190906130103.20961-1-peterx@redhat.com> (Peter Xu's message of "Fri, 6 Sep 2019 21:01:03 +0800")
Peter Xu <peterx@redhat.com> wrote:
> We've got max-postcopy-bandwidth parameter but it's not applied
> correctly after a postcopy recovery so the recovered migration stream
> will still eat the whole net bandwidth. Fix that up.
>
> Reported-by: Xiaohui Li <xiaohli@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> migration/migration.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Juan Quintela <quintela@redhat.com>
> diff --git a/migration/migration.c b/migration/migration.c
> index 8b9f2fe30a..b307813aa3 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3327,7 +3327,8 @@ void migrate_fd_connect(MigrationState *s, Error *error_in)
>
> if (resume) {
> /* This is a resumed migration */
> - rate_limit = INT64_MAX;
> + rate_limit = s->parameters.max_postcopy_bandwidth /
> + XFER_LIMIT_RATIO;
> } else {
> /* This is a fresh new migration */
> rate_limit = s->parameters.max_bandwidth / XFER_LIMIT_RATIO;
I was confused thinking that the two assignations were the same O:-)
next prev parent reply other threads:[~2019-09-06 13:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 13:01 [Qemu-devel] [PATCH] migration: Fix postcopy bw for recovery Peter Xu
2019-09-06 13:35 ` Juan Quintela [this message]
2019-09-12 10:21 ` Dr. David Alan Gilbert
2019-09-24 18:22 ` Markus Armbruster
2019-09-24 18:29 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgp9k0nu.fsf@trasno.org \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiaohli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).