From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33EADC433B4 for ; Mon, 12 Apr 2021 14:17:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A57561025 for ; Mon, 12 Apr 2021 14:17:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A57561025 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVxNO-0000Pj-AX for qemu-devel@archiver.kernel.org; Mon, 12 Apr 2021 10:17:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVxLj-0007rs-FF for qemu-devel@nongnu.org; Mon, 12 Apr 2021 10:15:35 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:42909) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVxLh-00056W-GI for qemu-devel@nongnu.org; Mon, 12 Apr 2021 10:15:35 -0400 Received: by mail-wr1-x431.google.com with SMTP id p6so6400961wrn.9 for ; Mon, 12 Apr 2021 07:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=RGSeucHlLodGFO4f98Bo18pTtMMaUbXBH/bSyMZ5ye4=; b=tSfEeXcdwYFC8ZIcLhVXrFrweMnCtjBohIXlhgb/pH1r2L1xrBIUlfRMUUeRiTnHrl L5o3BekYamK1snAmxBn7Huz7SbjWaKQwSTHiUlxvUnxOiHMSbtNI6nmyNsGp3pcKlWcH 3ooRQXPA4ywMZ335xu4+Pgw3FH9NjYybRBBefpMYUsDSiKT5uk+yCF2YM/NezdTON4aj 3wXA0KVEZQs2Xwm4Q00iO5d9B/kDChtj6VuEsRMzPzF4CFQVKVIePvBhksIAx8H68Hq8 RP+H+XEeJgfRLZDSVTEeh2N8E2fvSEorMhefaZJki2Irks4VFE6hUJ+E3JWy6hcTR8h6 k3kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=RGSeucHlLodGFO4f98Bo18pTtMMaUbXBH/bSyMZ5ye4=; b=s7YJ7apcm9xXFrj/iesPQ4BzQmncbHroHS9goSOilOYo4wKNIe6ns5V3tgaMOvD47Y umF082KqN2JSRFDKYUHV2IcpsKEyh9dFexYsRNoo7JcOtsREC54E9QvNvU3BVm63Ig33 oOGuRaYEZqFiVwf/pwpDU9iVMLYlkrAZSa1qyrHE6WppvxSGvXtCamb0VilyOinj2SP8 TQiWI0RiXkZJAgwWX//OQGob3XKyI52XyS6etlbvrAsWussXkEO/lf10BB9OvOHZQQke ivcUIm5kprcEkPjnmOmOoMYPS8hho1gEnbTxx9L5SaSdhAqi/f7pqZLwL/C9q4c/becD AKkg== X-Gm-Message-State: AOAM531xrt4tlA7Ss6bmqhJaVOpHfQxgFuF5jzaO0INTTLEs6JC5+YxE E+4bg4JRKGfUaL+w3JSFT1iFWw== X-Google-Smtp-Source: ABdhPJwTiAlMQHDPOBILYw93C5zPUPk4rUzzmdiQbLfxY5VUAhw1amdJbIZH+anpkzw6i96B/0YNYQ== X-Received: by 2002:adf:9d82:: with SMTP id p2mr31859706wre.234.1618236931570; Mon, 12 Apr 2021 07:15:31 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id e10sm16585890wrw.14.2021.04.12.07.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 07:15:30 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id DF8001FF7E; Mon, 12 Apr 2021 15:15:29 +0100 (BST) References: <20210326193701.5981-1-cfontana@suse.de> <20210326193701.5981-13-cfontana@suse.de> User-agent: mu4e 1.5.11; emacs 28.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Claudio Fontana Subject: Re: [RFC v12 12/65] target/arm: move physical address translation to cpu-mmu Date: Mon, 12 Apr 2021 15:13:16 +0100 In-reply-to: <20210326193701.5981-13-cfontana@suse.de> Message-ID: <87tuobmvwe.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Richard Henderson , qemu-devel@nongnu.org, Roman Bolshakov , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-D?= =?utf-8?Q?aud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Claudio Fontana writes: > get_phys_addr is needed for KVM too, and in turn it requires > the aa64_va_parameter* family of functions. > > Create cpu-mmu and cpu-mmu-sysemu to store these and > other mmu-related functions. > > Signed-off-by: Claudio Fontana > Reviewed-by: Richard Henderson > --- > target/arm/cpu-mmu.h | 119 ++ > target/arm/cpu.h | 3 - > target/arm/internals.h | 34 - > target/arm/cpu-mmu-sysemu.c | 2307 ++++++++++++++++++++++++++ > target/arm/cpu-mmu.c | 124 ++ > target/arm/cpu.c | 1 + > target/arm/tcg/helper.c | 2442 +--------------------------- I realise I reviewed the previous patch but we moved everything wholesale into target/arm/tcg only to move stuff right back out again. I can see there maybe an argument for a "move and pare down" approach but that should probably be expanded on in the comment for 2/65 (move helpers to tcg). Anyway: Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e