From: "Alex Bennée" <alex.bennee@linaro.org>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: fam@euphon.net, ehabkost@redhat.com, jsnow@redhat.com,
qemu-devel@nongnu.org, crosa@redhat.com, philmd@redhat.com
Subject: Re: [PATCH 2/4] python/qemu: accel: Add list_accel() method
Date: Tue, 03 Dec 2019 16:57:34 +0000 [thread overview]
Message-ID: <87tv6h9wjl.fsf@linaro.org> (raw)
In-Reply-To: <20191115180829.10275-3-wainersm@redhat.com>
Wainer dos Santos Moschetta <wainersm@redhat.com> writes:
> Since commit cbe6d6365a48 the command `qemu -accel help` returns
> the list of accelerators enabled in the QEMU binary. This adds
> the list_accel() method which return that same list.
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> ---
> python/qemu/accel.py | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/python/qemu/accel.py b/python/qemu/accel.py
> index 1b825126c5..a63ff980a9 100644
> --- a/python/qemu/accel.py
> +++ b/python/qemu/accel.py
> @@ -18,6 +18,7 @@ accelerators.
>
> import logging
> import os
> +import subprocess
>
> LOG = logging.getLogger(__name__)
>
> @@ -28,6 +29,25 @@ ADDITIONAL_ARCHES = {
> "aarch64" : "armhf"
> }
>
> +def list_accel(qemu_bin):
> + """
> + List accelerators enabled in the QEMU binary.
> +
> + @param qemu_bin (str): path to the QEMU binary.
> + @raise Exception: if failed to run `qemu -accel help`
> + @return a list of accelerator names.
> + """
> + if not qemu_bin:
> + return []
> + try:
> + out = subprocess.check_output("%s -accel help" % qemu_bin, shell=True)
> + except:
> + LOG.debug("Failed to get the list of accelerators in %s" %
> qemu_bin)
Ahh here it is. So I guess either mention the fact we will be using it
in the previous commit or bring it in here when we do use it.
I see we use LOG.debug for a bunch of failure reasons but surely
LOG.error is the more correct level for something that failed? I guess
it doesn't matter as we don't mess with the levels.
> + raise
> + lines = out.decode().splitlines()
> + # Skip the first line which is the header.
> + return [l.strip() for l in lines[1:] if l]
> +
> def kvm_available(target_arch=None):
> host_arch = os.uname()[4]
> if target_arch and target_arch != host_arch:
Anyway:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2019-12-03 17:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 18:08 [PATCH 0/4] python/qemu: New accel module and improvements Wainer dos Santos Moschetta
2019-11-15 18:08 ` [PATCH 1/4] python/qemu: Move kvm_available() to its own module Wainer dos Santos Moschetta
2019-12-03 16:21 ` Alex Bennée
2019-11-15 18:08 ` [PATCH 2/4] python/qemu: accel: Add list_accel() method Wainer dos Santos Moschetta
2019-12-03 16:57 ` Alex Bennée [this message]
2019-11-15 18:08 ` [PATCH 3/4] python/qemu: accel: Strengthen kvm_available() checks Wainer dos Santos Moschetta
2019-12-03 16:58 ` Alex Bennée
2019-11-15 18:08 ` [PATCH 4/4] python/qemu: accel: Add tcg_available() method Wainer dos Santos Moschetta
2019-12-03 17:00 ` Alex Bennée
2019-12-03 17:25 ` [PATCH 0/4] python/qemu: New accel module and improvements Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv6h9wjl.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).