From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWjTk-00064Z-Dh for qemu-devel@nongnu.org; Fri, 19 Feb 2016 06:44:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWjTf-0007nZ-Nt for qemu-devel@nongnu.org; Fri, 19 Feb 2016 06:44:08 -0500 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:37466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWjTf-0007nU-9b for qemu-devel@nongnu.org; Fri, 19 Feb 2016 06:44:03 -0500 Received: by mail-wm0-x229.google.com with SMTP id g62so67165927wme.0 for ; Fri, 19 Feb 2016 03:44:03 -0800 (PST) References: <1454059965-23402-1-git-send-email-a.rigo@virtualopensystems.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1454059965-23402-1-git-send-email-a.rigo@virtualopensystems.com> Date: Fri, 19 Feb 2016 11:44:00 +0000 Message-ID: <87twl4diwv.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC v7 00/16] Slow-path for atomic instruction translation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alvise Rigo Cc: mttcg@listserver.greensocs.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, pbonzini@redhat.com, jani.kokkonen@huawei.com, tech@virtualopensystems.com, rth@twiddle.net Alvise Rigo writes: > This is the seventh iteration of the patch series which applies to the > upstream branch of QEMU (v2.5.0-rc4). > > Changes versus previous versions are at the bottom of this cover letter. > > The code is also available at following repository: > https://git.virtualopensystems.com/dev/qemu-mt.git > branch: > slowpath-for-atomic-v7-no-mttcg OK I'm done on this review pass. I think generally we are in pretty good shape although I await to see what extra needs to be done for the MTTCG case. We are coming up to soft-freeze on 1/3/16 and it would be nice to get this merged by then. As it is a fairly major chunk of work it would need to get the initial commit by that date. However before we can get to that stage we need some review from the maintainers. For your next version can you please: - Drop the RFC tag, I think we have had enough comment ;-) - Make sure you CC the TCG maintainers (Paolo, Peter C and Richard Henderson) - Also CC the ARM maintainers (Peter M) - Be ready for a fast turnaround Paolo/Richard, Do you have any comments on this iteration? -- Alex Bennée