From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Greg Kurz" <groug@kaod.org>,
qemu-devel@nongnu.org, "Eric Auger" <eric.auger@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 0/2] qapi: Move RTC_CHANGE back out of target schema
Date: Sat, 25 Sep 2021 09:43:48 +0200 [thread overview]
Message-ID: <87v92pksln.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20210924140142.31398-1-peter.maydell@linaro.org> (Peter Maydell's message of "Fri, 24 Sep 2021 15:01:40 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> This patchset moves RTC_CHANGE back to misc.json, effectively
> reverting commit 183e4281a30962, which moved the RTC_CHANGE event to
> the target schema. That change was an attempt to make the event
> target-specific to improve introspection, but the event isn't really
> target-specific: it's machine or device specific. Putting RTC_CHANGE
> in the target schema with an ifdef list reduces maintainability (by
> adding an if: list with a long list of targets that needs to be
> manually updated as architectures are added or removed or as new
> devices gain the RTC_CHANGE functionality) and increases compile time
> (by preventing RTC devices which emit the event from being "compile
> once" rather than "compile once per target", because
> qapi-events-misc-target.h uses TARGET_* ifdefs, which are poisoned in
> "compile once" files.)
>
> Patch 2 fixes a minor documentation issue that I noticed while
> I was doing this -- we didn't document that the units used in
> the RTC_CHANGE event are seconds.
Series
Reviewed-by: Markus Armbruster <armbru@redhat.com>
An additional patch documenting that not all RTCs implement RTC_CHANGE
would be nice. Listing them would be even nicer.
An additional patch adding @qom-path event argument would be nice.
next prev parent reply other threads:[~2021-09-25 7:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 14:01 [PATCH 0/2] qapi: Move RTC_CHANGE back out of target schema Peter Maydell
2021-09-24 14:01 ` [PATCH 1/2] " Peter Maydell
2021-09-24 14:07 ` Greg Kurz
2021-09-24 14:01 ` [PATCH 2/2] qapi: Document the units for the offset argument to RTC_CHANGE Peter Maydell
2021-09-25 7:43 ` Markus Armbruster [this message]
2022-02-21 18:06 ` [PATCH 0/2] qapi: Move RTC_CHANGE back out of target schema Peter Maydell
2022-02-22 11:35 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v92pksln.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=eblake@redhat.com \
--cc=eric.auger@redhat.com \
--cc=groug@kaod.org \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).