From: Markus Armbruster <armbru@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Corey Minyard" <minyard@acm.org>,
"David Hildenbrand" <david@redhat.com>,
"Pan Nengyuan" <pannengyuan@huawei.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH 1/2] hw/ipmi/bmc: Delay timer_new_ns() from init to realize to avoid memleaks
Date: Tue, 18 Feb 2020 10:29:44 +0100 [thread overview]
Message-ID: <87v9o4gs53.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAFEAcA8AD30UPqDxZ6myimhsYsgRu9A8pTCnq7WoAXewKUDN8g@mail.gmail.com> (Peter Maydell's message of "Mon, 17 Feb 2020 17:27:13 +0000")
Peter Maydell <peter.maydell@linaro.org> writes:
> On Mon, 17 Feb 2020 at 17:20, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>> Quick check with TYPE_BITBAND which is a SysBus device, we have:
>>
>> static void bitband_realize(DeviceState *dev, Error **errp)
>> {
>> BitBandState *s = BITBAND(dev);
>>
>> if (!s->source_memory) {
>> error_setg(errp, "source-memory property not set");
>> return;
>> }
>>
>> address_space_init(&s->source_as, s->source_memory, "bitband-source");
>> }
>>
>> Do we need the equivalent:
>>
>> static void bitband_unrealize(DeviceState *dev, Error **errp)
>> {
>> BitBandState *s = BITBAND(dev);
>>
>> address_space_destroy(&s->source_as);
>> }
>>
>> Or instead mark the device user_creatable=false because of the link to a
>> TYPE_MEMORY_REGION?
>
> I don't believe that this device is user-creatable. The
> base class sysbus_device_class_init() sets user_creatable
> to false by default for all sysbus devices, and a sysbus
> device which wants to opt into being user-created has to
> set it to true.
As far as I can tell, you additionally have to
machine_class_allow_dynamic_sysbus_dev(). Sysbus is special.
> Also the device's type name string is "ARM,bitband-memory"
> and the -device option at least does not like the comma
> in the middle of the name, so I don't know how you'd
> create it on the command line even if it wasn't marked
> not user-creatable.
Double the comma.
If I remember correctly, the use of comma in type comes from IEEE-1275.
It's quite inappropriate for QEMU.
next prev parent reply other threads:[~2020-02-18 9:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 15:47 [PATCH 0/2] hw: Delay timer_new() from init to realize to avoid memleaks Philippe Mathieu-Daudé
2020-02-15 15:47 ` [PATCH 1/2] hw/ipmi/bmc: Delay timer_new_ns() " Philippe Mathieu-Daudé
2020-02-16 19:43 ` Corey Minyard
2020-02-17 13:25 ` Peter Maydell
2020-02-17 13:48 ` Philippe Mathieu-Daudé
2020-02-17 14:06 ` Peter Maydell
2020-02-17 16:15 ` Philippe Mathieu-Daudé
2020-02-17 16:32 ` Peter Maydell
2020-02-17 17:12 ` Philippe Mathieu-Daudé
2020-02-17 17:14 ` Peter Maydell
2020-02-17 17:19 ` Philippe Mathieu-Daudé
2020-02-17 17:27 ` Peter Maydell
2020-02-18 9:29 ` Markus Armbruster [this message]
2020-02-18 9:21 ` Markus Armbruster
2020-02-17 19:33 ` Markus Armbruster
2020-02-15 15:47 ` [PATCH 2/2] hw/sd/sd: " Philippe Mathieu-Daudé
2020-02-17 13:26 ` Peter Maydell
2020-06-05 5:05 ` Philippe Mathieu-Daudé
2020-02-16 2:10 ` [PATCH 0/2] hw: Delay timer_new() " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9o4gs53.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=minyard@acm.org \
--cc=pannengyuan@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).