From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-discuss <qemu-discuss@nongnu.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Juan Rafael García Blanco" <juanrgar@gmail.com>
Subject: Re: [Qemu-devel] [Qemu-discuss] qemu-io-cmds does not compile on macOS
Date: Mon, 24 Jun 2019 10:14:00 +0100 [thread overview]
Message-ID: <87v9wv1h2f.fsf@zen.linaroharston> (raw)
In-Reply-To: <CAFEAcA8mcQJiYkHdzNJT3m+9-vak_CWaxGBQ0TME1tZQQK7f_w@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On Sun, 23 Jun 2019 at 16:22, Juan Rafael García Blanco
> <juanrgar@gmail.com> wrote:
>> I think the latest changes to qemu-io-cmds.c make it impossible to compile under macOS. It now uses clock_gettime, which is not available in this OS. I’m using 10.9.5; I think this function is now included in 10.12.
>>
>> I would step up to try to prepare a patch that uses a replacement in case it is being compiled in a macOS version that does not include that function. But I do not know if you want to support these ‘old' macOS versions…
>
> Hi; thanks for this report. (This kind of bug report is better sent
> to qemu-devel or to the launchpad bug tracker -- qemu-discuss
> is mostly user-to-user conversations, and developers tend to
> be on -devel; I've cc'd -devel on this.)
>
> Our official support policy is that we support building with the
> two most recent versions of macOS; in practice we might support
> building with some earlier versions; as of commit 5588840ff77800e839
> we definitely dropped support for anything earlier than 10.10.
> So in theory we don't strongly care about anything before 10.13
> at the moment; but if it's easy to avoid the problem it might be
> worth doing that.
>
> Alex, it looks like the relevant commit was one of yours.
Which commit was that?
> Could you have a look at how easy it would be to support
> systems without clock_gettime/CLOCK_MONOTONIC ?
> I notice that other places in QEMU have #ifdeffery for
> a lack of CLOCK_MONOTONIC, so we should ideally be
> consistent, and either support systems without it, or else
> say we require it and remove the remaining legacy ifdefs...
Ahh was this the changes to qemu-iocmds to use proper monotonic clocks
to avoid /0 that was occuring with gettimeofday?
In the main code we have comments about:
/* XXX: using gettimeofday leads to problems if the date
changes, so it should be avoided. */
Is this the only option for old MacOS?
>
> thanks
> -- PMM
--
Alex Bennée
prev parent reply other threads:[~2019-06-24 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C95C3BAC-3DE1-44F3-BB08-715D3121371A@gmail.com>
2019-06-23 17:28 ` [Qemu-devel] [Qemu-discuss] qemu-io-cmds does not compile on macOS Peter Maydell
2019-06-24 9:14 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9wv1h2f.fsf@zen.linaroharston \
--to=alex.bennee@linaro.org \
--cc=juanrgar@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-discuss@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).