From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
lukasstraub2@web.de, qemu-devel@nongnu.org
Subject: Re: [PATCH] yank: Avoid linking into executables that don't want it
Date: Tue, 16 Mar 2021 16:36:44 +0100 [thread overview]
Message-ID: <87wnu7glf7.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <cfda2d65-eb0a-b18c-f6a8-80ad1652cf42@redhat.com> (Eric Blake's message of "Tue, 16 Mar 2021 09:07:45 -0500")
Eric Blake <eblake@redhat.com> writes:
> On 3/16/21 8:59 AM, Markus Armbruster wrote:
>> util/yank.c and stubs/yank.c are both in libqemuutil.a, even though
>> their external symbols conflict. The linker happens to pick the
>> former. This links a bunch of unneeded code into the executables that
>> actually want the latter: qemu-io, qemu-img, qemu-nbd, and several
>> tests. Amazingly, none of them fails to link.
>>
>> To fix this, the non-stub yank.c from sourceset util_ss to sourceset
>> qmp_ss. This requires moving it from util/ to monitor/.
>>
>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> {util => monitor}/yank.c | 0
>> MAINTAINERS | 2 +-
>> monitor/meson.build | 1 +
>> util/meson.build | 1 -
>> 4 files changed, 2 insertions(+), 2 deletions(-)
>> rename {util => monitor}/yank.c (100%)
>
> I'm still determining if I need an NBD pull request for soft freeze
> today; if so, I'm happy to include this one if it doesn't make it into
> the tree elsewhere first. I also consider it to be a build issue and
> therefore suitable for inclusion in -rc1 if it misses the boat today.
It's not urgent, just something I spotted when I looked for buddies of
another bug that bit me.
next prev parent reply other threads:[~2021-03-16 15:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 13:59 [PATCH] yank: Avoid linking into executables that don't want it Markus Armbruster
2021-03-16 14:06 ` Eric Blake
2021-03-16 15:34 ` Markus Armbruster
2021-03-16 14:07 ` Eric Blake
2021-03-16 15:36 ` Markus Armbruster [this message]
2021-03-17 20:50 ` Lukas Straub
2021-03-23 4:54 ` Thomas Huth
2021-03-23 9:43 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnu7glf7.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=lukasstraub2@web.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).