From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A79C0C433E0 for ; Tue, 2 Feb 2021 15:35:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34C3264F68 for ; Tue, 2 Feb 2021 15:35:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34C3264F68 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57992 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6xiI-0000sv-96 for qemu-devel@archiver.kernel.org; Tue, 02 Feb 2021 10:35:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6xUj-0001qn-Dv for qemu-devel@nongnu.org; Tue, 02 Feb 2021 10:21:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6xUg-0002ZZ-Tw for qemu-devel@nongnu.org; Tue, 02 Feb 2021 10:21:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612279289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/6zeKlic1XXhoTn6tyBVHVh99dqdSWp+A6RlFE0NQgU=; b=R4wwfCwW5Sa1EIWAMzOHTgOYBPFYBqsiS4l2T3b9qAIlwGeK/qjEpbEFe3jK2cj1aucQFK 7cF8gQ9/Vx18jsHruHvPoOOwHZI6E+RhS9mN5SDaTZ7b4ExcscV+XK8fbgyn0sC9f2rPyd Aw5CEHbwdmYlKD9LfVa1PDm1vHy8fp4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-au6_5vsCO9O9ZYneknis4Q-1; Tue, 02 Feb 2021 10:21:26 -0500 X-MC-Unique: au6_5vsCO9O9ZYneknis4Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 48EB7CE662 for ; Tue, 2 Feb 2021 15:21:25 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-115-51.ams2.redhat.com [10.36.115.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1AE523828; Tue, 2 Feb 2021 15:21:25 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A4691113865F; Tue, 2 Feb 2021 16:21:23 +0100 (CET) From: Markus Armbruster To: Eric Blake Subject: Re: [PATCH v2 3/4] migration: Fix cache_init()'s "Failed to allocate" error messages References: <20210202141734.2488076-1-armbru@redhat.com> <20210202141734.2488076-4-armbru@redhat.com> <00a237bc-0d15-a27b-cd2f-e8dad4cccab3@redhat.com> Date: Tue, 02 Feb 2021 16:21:23 +0100 In-Reply-To: <00a237bc-0d15-a27b-cd2f-e8dad4cccab3@redhat.com> (Eric Blake's message of "Tue, 2 Feb 2021 08:23:07 -0600") Message-ID: <87wnvq4hsc.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.386, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eric Blake writes: > On 2/2/21 8:17 AM, Markus Armbruster wrote: >> cache_init() attempts to handle allocation failure.. The two error > > The double . looks odd. Typo. Perhaps the maintainer can take care of it. >> messages are garbage, as untested error messages commonly are: >> >> Parameter 'cache size' expects Failed to allocate cache >> Parameter 'cache size' expects Failed to allocate page cache >> >> Fix them to just >> >> Failed to allocate cache >> Failed to allocate page cache >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Dr. David Alan Gilbert >> --- >> migration/page_cache.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >>