* [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment
@ 2019-08-23 10:39 Dr. David Alan Gilbert (git)
2019-08-23 10:46 ` Daniel P. Berrangé
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2019-08-23 10:39 UTC (permalink / raw)
To: qemu-devel, quintela, berrange
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Commit 11808bb removed the non-iovec based write support,
the comment hung on.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/qemu-file.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index e33c46764f..075faf03c3 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -201,9 +201,8 @@ static void qemu_iovec_release_ram(QEMUFile *f)
/**
* Flushes QEMUFile buffer
*
- * If there is writev_buffer QEMUFileOps it uses it otherwise uses
- * put_buffer ops. This will flush all pending data. If data was
- * only partially flushed, it will set an error state.
+ * This will flush all pending data. If data was only partially flushed, it
+ * will set an error state.
*/
void qemu_fflush(QEMUFile *f)
{
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment
2019-08-23 10:39 [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment Dr. David Alan Gilbert (git)
@ 2019-08-23 10:46 ` Daniel P. Berrangé
2019-08-26 8:01 ` Stefano Garzarella
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrangé @ 2019-08-23 10:46 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: qemu-devel, quintela
On Fri, Aug 23, 2019 at 11:39:46AM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Commit 11808bb removed the non-iovec based write support,
> the comment hung on.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/qemu-file.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment
2019-08-23 10:39 [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment Dr. David Alan Gilbert (git)
2019-08-23 10:46 ` Daniel P. Berrangé
@ 2019-08-26 8:01 ` Stefano Garzarella
2019-09-11 11:20 ` Juan Quintela
2019-09-12 10:16 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 5+ messages in thread
From: Stefano Garzarella @ 2019-08-26 8:01 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: berrange, qemu-devel, quintela
On Fri, Aug 23, 2019 at 11:39:46AM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Commit 11808bb removed the non-iovec based write support,
> the comment hung on.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/qemu-file.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
> index e33c46764f..075faf03c3 100644
> --- a/migration/qemu-file.c
> +++ b/migration/qemu-file.c
> @@ -201,9 +201,8 @@ static void qemu_iovec_release_ram(QEMUFile *f)
> /**
> * Flushes QEMUFile buffer
> *
> - * If there is writev_buffer QEMUFileOps it uses it otherwise uses
> - * put_buffer ops. This will flush all pending data. If data was
> - * only partially flushed, it will set an error state.
> + * This will flush all pending data. If data was only partially flushed, it
> + * will set an error state.
> */
> void qemu_fflush(QEMUFile *f)
> {
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment
2019-08-23 10:39 [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment Dr. David Alan Gilbert (git)
2019-08-23 10:46 ` Daniel P. Berrangé
2019-08-26 8:01 ` Stefano Garzarella
@ 2019-09-11 11:20 ` Juan Quintela
2019-09-12 10:16 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 5+ messages in thread
From: Juan Quintela @ 2019-09-11 11:20 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git); +Cc: berrange, qemu-devel
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Commit 11808bb removed the non-iovec based write support,
> the comment hung on.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment
2019-08-23 10:39 [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment Dr. David Alan Gilbert (git)
` (2 preceding siblings ...)
2019-09-11 11:20 ` Juan Quintela
@ 2019-09-12 10:16 ` Dr. David Alan Gilbert
3 siblings, 0 replies; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2019-09-12 10:16 UTC (permalink / raw)
To: qemu-devel, quintela, berrange
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Commit 11808bb removed the non-iovec based write support,
> the comment hung on.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Queued
> ---
> migration/qemu-file.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
> index e33c46764f..075faf03c3 100644
> --- a/migration/qemu-file.c
> +++ b/migration/qemu-file.c
> @@ -201,9 +201,8 @@ static void qemu_iovec_release_ram(QEMUFile *f)
> /**
> * Flushes QEMUFile buffer
> *
> - * If there is writev_buffer QEMUFileOps it uses it otherwise uses
> - * put_buffer ops. This will flush all pending data. If data was
> - * only partially flushed, it will set an error state.
> + * This will flush all pending data. If data was only partially flushed, it
> + * will set an error state.
> */
> void qemu_fflush(QEMUFile *f)
> {
> --
> 2.21.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-12 10:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-23 10:39 [Qemu-devel] [PATCH] qemu-file: Rework old qemu_fflush comment Dr. David Alan Gilbert (git)
2019-08-23 10:46 ` Daniel P. Berrangé
2019-08-26 8:01 ` Stefano Garzarella
2019-09-11 11:20 ` Juan Quintela
2019-09-12 10:16 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).