From: Markus Armbruster <armbru@redhat.com>
To: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, dgilbert@redhat.com,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command
Date: Tue, 07 May 2019 13:09:17 +0200 [thread overview]
Message-ID: <87woj2cyhu.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20190501053522.10967-1-sjitindarsingh@gmail.com> (Suraj Jitindar Singh's message of "Wed, 1 May 2019 15:35:21 +1000")
Suraj Jitindar Singh <sjitindarsingh@gmail.com> writes:
> Add a monitor command "dump-stack" to be used to dump the stack for the
> current cpu.
I guess this is just for debugging. Correct?
Shouldn't this be "info stack", to match "info registers" and "info
cpustats"?
>
> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
> ---
> hmp-commands.hx | 13 +++++++++++++
> hmp.h | 1 +
> include/qom/cpu.h | 10 ++++++++++
> monitor.c | 12 ++++++++++++
> qom/cpu.c | 10 ++++++++++
> 5 files changed, 46 insertions(+)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 9b4035965c..965ccdea28 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -862,6 +862,19 @@ ETEXI
> },
>
> STEXI
> +@item dump-stack
> +@findex dump-stack
> +dump stack of the cpu
> +ETEXI
> + {
> + .name = "dump-stack",
> + .args_type = "",
> + .params = "",
> + .help = "dump stack",
> + .cmd = hmp_dumpstack,
> + },
> +
> +STEXI
> @item pmemsave @var{addr} @var{size} @var{file}
> @findex pmemsave
> save to disk physical memory dump starting at @var{addr} of size @var{size}.
> diff --git a/hmp.h b/hmp.h
> index 43617f2646..e6edf1215c 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -51,6 +51,7 @@ void hmp_announce_self(Monitor *mon, const QDict *qdict);
> void hmp_cpu(Monitor *mon, const QDict *qdict);
> void hmp_memsave(Monitor *mon, const QDict *qdict);
> void hmp_pmemsave(Monitor *mon, const QDict *qdict);
> +void hmp_dumpstack(Monitor *mon, const QDict *qdict);
> void hmp_ringbuf_write(Monitor *mon, const QDict *qdict);
> void hmp_ringbuf_read(Monitor *mon, const QDict *qdict);
> void hmp_cont(Monitor *mon, const QDict *qdict);
> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
> index 08abcbd3fe..f2e83e9918 100644
> --- a/include/qom/cpu.h
> +++ b/include/qom/cpu.h
> @@ -181,6 +181,7 @@ typedef struct CPUClass {
> int (*memory_rw_debug)(CPUState *cpu, vaddr addr,
> uint8_t *buf, int len, bool is_write);
> void (*dump_state)(CPUState *cpu, FILE *, int flags);
> + void (*dump_stack)(CPUState *cpu, FILE *f);
> GuestPanicInformation* (*get_crash_info)(CPUState *cpu);
> void (*dump_statistics)(CPUState *cpu, int flags);
> int64_t (*get_arch_id)(CPUState *cpu);
> @@ -568,6 +569,15 @@ enum CPUDumpFlags {
> void cpu_dump_state(CPUState *cpu, FILE *f, int flags);
>
> /**
> + * cpu_dump_stack:
> + * @cpu: The CPU whose stack is to be dumped.
> + * @f: If non-null, dump to this stream, else to current print sink.
> + *
> + * Dumps CPU stack.
> + */
> +void cpu_dump_stack(CPUState *cpu, FILE *f);
> +
> +/**
> * cpu_dump_statistics:
> * @cpu: The CPU whose state is to be dumped.
> * @flags: Flags what to dump.
> diff --git a/monitor.c b/monitor.c
> index 9b5f10b475..dbec2e4376 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1299,6 +1299,18 @@ static void hmp_info_registers(Monitor *mon, const QDict *qdict)
> }
> }
>
> +void hmp_dumpstack(Monitor *mon, const QDict *qdict)
> +{
> + CPUState *cs = mon_get_cpu();
> +
> + if (!cs) {
> + monitor_printf(mon, "No CPU available\n");
> + return;
> + }
> +
> + cpu_dump_stack(cs, NULL);
> +}
> +
> #ifdef CONFIG_TCG
> static void hmp_info_jit(Monitor *mon, const QDict *qdict)
> {
> diff --git a/qom/cpu.c b/qom/cpu.c
> index 3c5493c96c..0dc10004f4 100644
> --- a/qom/cpu.c
> +++ b/qom/cpu.c
> @@ -230,6 +230,16 @@ void cpu_dump_state(CPUState *cpu, FILE *f, int flags)
> }
> }
>
> +void cpu_dump_stack(CPUState *cpu, FILE *f)
> +{
> + CPUClass *cc = CPU_GET_CLASS(cpu);
> +
> + if (cc->dump_stack) {
> + cpu_synchronize_state(cpu);
> + cc->dump_stack(cpu, f);
> + }
> +}
Silently does nothing when the CPU doesn't implement dump_stack().
Matches "info registers" and "info cpustats". Awful UI, but at least
it's consistently awful.
> +
> void cpu_dump_statistics(CPUState *cpu, int flags)
> {
> CPUClass *cc = CPU_GET_CLASS(cpu);
next prev parent reply other threads:[~2019-05-07 11:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 5:35 [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command Suraj Jitindar Singh
2019-05-01 5:35 ` Suraj Jitindar Singh
2019-05-01 5:35 ` [Qemu-devel] [PATCH 2/2] ppc: Add dump-stack implementation Suraj Jitindar Singh
2019-05-01 5:35 ` Suraj Jitindar Singh
2019-05-01 9:48 ` Alexey Kardashevskiy
2019-05-01 9:48 ` Alexey Kardashevskiy
2019-05-02 0:43 ` David Gibson
2019-05-02 0:43 ` David Gibson
2019-05-02 3:47 ` Alexey Kardashevskiy
2019-05-02 3:47 ` Alexey Kardashevskiy
2019-05-06 3:39 ` David Gibson
2019-05-02 13:59 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2019-05-02 13:59 ` Greg Kurz
2019-05-07 11:24 ` [Qemu-devel] " Markus Armbruster
2019-05-01 10:44 ` [Qemu-devel] [PATCH 1/2] monitor: Add dump-stack command Dr. David Alan Gilbert
2019-05-01 10:44 ` Dr. David Alan Gilbert
2019-05-02 0:44 ` David Gibson
2019-05-02 0:44 ` David Gibson
2019-05-02 2:15 ` [Qemu-devel] [Qemu-ppc] " Alexey Kardashevskiy
2019-05-02 2:15 ` Alexey Kardashevskiy
2019-05-07 11:21 ` Markus Armbruster
2019-05-07 11:09 ` Markus Armbruster [this message]
2019-05-08 10:26 ` [Qemu-devel] " Dr. David Alan Gilbert
2019-05-08 13:10 ` Markus Armbruster
2019-05-08 13:15 ` Dr. David Alan Gilbert
2019-06-21 0:51 ` Suraj Jitindar Singh
2019-06-24 8:57 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woj2cyhu.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sjitindarsingh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).