From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21BA0C433F5 for ; Fri, 5 Nov 2021 06:12:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 917FE61108 for ; Fri, 5 Nov 2021 06:12:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 917FE61108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1misSW-00023w-Ea for qemu-devel@archiver.kernel.org; Fri, 05 Nov 2021 02:12:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35496) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1misR9-0000gn-IA for qemu-devel@nongnu.org; Fri, 05 Nov 2021 02:10:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58671) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1misR6-0003H9-2i for qemu-devel@nongnu.org; Fri, 05 Nov 2021 02:10:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636092647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZohW6aRrFc2jSUWaEdgsjcy+Xi6QCvg8InR4ILPZmQA=; b=e0+zHKr4S7oK7q8cBIQ0rBHQa4uNy33SaZr43h1DaA4p3ToR9vQODsckXXge/AeMld6bwa y+oVBJcALdvslP/mcoLdeUA/P+2l2CR7xGY81ZF/UVEWI+bhPV23wxmWmTxgAJgzdI1O7l VZ4zn8HagMLxnIZV4ziu2UOzQvmwuQE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-UzGeDGEuM3i6OmqEq_8Zwg-1; Fri, 05 Nov 2021 02:10:42 -0400 X-MC-Unique: UzGeDGEuM3i6OmqEq_8Zwg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C37731006AA2; Fri, 5 Nov 2021 06:10:41 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F46260C13; Fri, 5 Nov 2021 06:10:41 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id F115E11380A7; Fri, 5 Nov 2021 07:10:39 +0100 (CET) From: Markus Armbruster To: "Zhang, Chen" Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for filter-mirror/redirector References: <20211028090556.3168043-1-chen.zhang@intel.com> <20211028090556.3168043-2-chen.zhang@intel.com> <94f96089-f8a8-d3d4-18c3-26917952fc14@redhat.com> Date: Fri, 05 Nov 2021 07:10:39 +0100 In-Reply-To: (Chen Zhang's message of "Fri, 5 Nov 2021 05:29:24 +0000") Message-ID: <87y2635e00.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.648, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang , qemu-dev , Li Zhijian Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" "Zhang, Chen" writes: >> -----Original Message----- >> From: Jason Wang >> Sent: Friday, November 5, 2021 12:03 PM >> To: Zhang, Chen >> Cc: Markus Armbruster ; qemu-dev > devel@nongnu.org>; Li Zhijian >> Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol for f= ilter-mirror/redirector >>=20 >> On Fri, Nov 5, 2021 at 11:27 AM Zhang, Chen wrote= : >> > >> > >> > >> > > -----Original Message----- >> > > From: Jason Wang >> > > Sent: Friday, November 5, 2021 11:17 AM >> > > To: Zhang, Chen ; Markus Armbruster >> > > >> > > Cc: qemu-dev ; Li Zhijian >> > > >> > > Subject: Re: [PATCH V5 1/3] net/filter: Optimize transfer protocol >> > > for filter- mirror/redirector >> > > >> > > >> > > =E5=9C=A8 2021/11/4 =E4=B8=8B=E5=8D=881:37, Zhang, Chen =E5=86=99=E9= =81=93: >> > > > Hi Jason/Markus, >> > > > >> > > > Rethink about it, How about keep the original "vnet_hdr_support" >> > > > function, And add a new optional parameter "auto_vnet_hdr" for fil= ters/compare? >> > > >> > > >> > > It's a way but rethink of the whole thing. I wonder what if we just >> > > enable "vnet_hdr_support" by default for filter and colo-compare? >> > >> > It's works by default for user use -device virtio-net-pci and e1000... >> > But it can't resolve this series motivation, how to fix/check user con= figuration issue: >> > For example user enable " vnet_hdr_support " filter-mirror and disable >> > " vnet_hdr_support" filter-redirector And connect both filter modules = by chardev socket. >> > In this case guest will get wrong network workload and filters didn=E2= =80=99t >> > perceive any abnormalities, but in fact, the whole system is no longer= working. >> > This series will report error and try to correct it. >>=20 >> The problem is how "auto_vnet_hdr" help in this case. It's a new paramet= er >> which may lead to more wrong configuration? > > No, the "auto_vnet_hdr" will fix most the wrong configuration issues as "= vnet_hdr_support" correct setting. > When we enable the "auto_vnet_hdr", the original "vnet_hdr_support" will = no effect. I don't know enough to help much here. What I do know: having to specify an obscure parameter to get a nicer user interface is backwards. Is this the case here?