From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4D4C3B18C for ; Thu, 13 Feb 2020 19:40:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 620032086A for ; Thu, 13 Feb 2020 19:40:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hfzDWyid" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 620032086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2KM4-0004iE-Hm for qemu-devel@archiver.kernel.org; Thu, 13 Feb 2020 14:40:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38296) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2KKA-0003dv-Pd for qemu-devel@nongnu.org; Thu, 13 Feb 2020 14:38:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2KK9-0002ns-SR for qemu-devel@nongnu.org; Thu, 13 Feb 2020 14:38:58 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27321 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j2KK9-0002lR-OG for qemu-devel@nongnu.org; Thu, 13 Feb 2020 14:38:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581622736; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YMv0ZJpshCdu012TrGb/C4AwbQ67CWaoUFp6xRyxfOA=; b=hfzDWyidSBm7MXDcx8KI2iqmhsjc5ZVxalnVNr7DbpZfj+rYQxiTxh2kOEMTnVpA81eCG6 si+u0q64MJAYkdEPUBHPiapFYdGKrXuzyxQjGRGweEzn8y78Ik21RofIf9ARchcksUW7n5 5+lHE3q/KRv1Dj4SsJEj7/6OW2g4rv4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-90-DIkGocOvOaKoFIA_KmS08A-1; Thu, 13 Feb 2020 14:38:53 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 792AB800E21 for ; Thu, 13 Feb 2020 19:38:52 +0000 (UTC) Received: from redhat.com (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3923D1001DEF; Thu, 13 Feb 2020 19:38:52 +0000 (UTC) From: Juan Quintela To: "Dr. David Alan Gilbert" Subject: Re: [PATCH v5 2/8] migration: Add support for modules In-Reply-To: <20200211105446.GE2751@work-vm> (David Alan Gilbert's message of "Tue, 11 Feb 2020 10:54:46 +0000") References: <20200129115655.10414-1-quintela@redhat.com> <20200129115655.10414-3-quintela@redhat.com> <20200211105446.GE2751@work-vm> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Thu, 13 Feb 2020 20:38:48 +0100 Message-ID: <87y2t6jn07.fsf@secure.laptop> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: DIkGocOvOaKoFIA_KmS08A-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Laurent Vivier , Thomas Huth , "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" , Eduardo Habkost , qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" "Dr. David Alan Gilbert" wrote: > * Juan Quintela (quintela@redhat.com) wrote: >> So we don't have to compile everything in, or have ifdefs >>=20 >> Signed-off-by: Juan Quintela > > As far as I can tell this matches the way all the rest of the module > stuff works, so: > > Reviewed-by: Dr. David Alan Gilbert Thanks > (Although I wish it was documented somewhere). I had to learn to use it with grep :-p