From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/7] qapi: switch x-input-send-event from console to device+head
Date: Fri, 15 Jan 2016 17:25:49 +0100 [thread overview]
Message-ID: <87y4bq4xo2.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1452601779-5790-4-git-send-email-kraxel@redhat.com> (Gerd Hoffmann's message of "Tue, 12 Jan 2016 13:29:36 +0100")
Gerd Hoffmann <kraxel@redhat.com> writes:
> Use display device qdev id and head number instead of console index to
> specify the QemuConsole. This makes things consistent with input
> devices (for input routing) and vnc server configuration, which both use
> display and head too.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> qapi-schema.json | 32 +++++++++++++++++---------------
> qmp-commands.hx | 15 ++++++++-------
> ui/input.c | 15 ++++++++++-----
> 3 files changed, 35 insertions(+), 27 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 2e31733..3884479 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3748,24 +3748,24 @@
> #
> # Send input event(s) to guest.
> #
> -# @console: #optional console to send event(s) to.
> -# This parameter can be used to send the input event to
> -# specific input devices in case (a) multiple input devices
> -# of the same kind are added to the virtual machine and (b)
> -# you have configured input routing (see docs/multiseat.txt)
> -# for those input devices. If input routing is not
> -# configured this parameter has no effect.
> -# If @console is missing, only devices that aren't associated
> -# with a console are admissible.
> -# If @console is specified, it must exist, and both devices
> -# associated with that console and devices not associated with a
> -# console are admissible, but the former take precedence.
> -
> -#
> +# @device: #optional display device to send event(s) to.
> +# @head: #optional head to send event(s) to, in case the
> +# display device supports multiple scanouts.
> # @events: List of InputEvent union.
> #
> # Returns: Nothing on success.
> #
> +# The @display and @head parameters can be used to send the input
> +# event to specific input devices in case (a) multiple input devices
> +# of the same kind are added to the virtual machine and (b) you have
> +# configured input routing (see docs/multiseat.txt) for those input
> +# devices. The parameters work exactly like the device and head
> +# properties of input devices. If @device is missing, only devices
> +# that have no input routing config are admissible. If @device is
> +# specified, both input devices with and without input routing config
> +# are admissible, but devices with input routing config take
> +# precedence.
> +
> # Since: 2.2
> #
> # Note: this command is experimental, and not a stable API. Things that
> @@ -3775,7 +3775,9 @@
> #
> ##
> { 'command': 'x-input-send-event',
> - 'data': { '*console':'int', 'events': [ 'InputEvent' ] } }
> + 'data': { '*device': 'str',
> + '*head' : 'int',
> + 'events' : [ 'InputEvent' ] } }
>
> ##
> # @NumaOptions
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index db072a6..bda1fa6 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -4614,7 +4614,8 @@ Send input event to guest.
>
> Arguments:
>
> -- "console": console index. (json-int, optional)
> +- "device": display device. (json-str, optional)
> +- "head": display head. (json-int, optional)
> - "events": list of input events.
Suggest to drop the periods.
[...]
next prev parent reply other threads:[~2016-01-15 16:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 12:29 [Qemu-devel] [PATCH 1/7] console: add qemu_console_lookup_by_device_name Gerd Hoffmann
2016-01-12 12:29 ` [Qemu-devel] [PATCH 2/7] console: use qemu_console_lookup_by_device_name in qemu_input_handler_bind Gerd Hoffmann
2016-01-12 12:43 ` Daniel P. Berrange
2016-01-12 12:29 ` [Qemu-devel] [PATCH 3/7] console: use qemu_console_lookup_by_device_name in vnc_display_open Gerd Hoffmann
2016-01-12 12:43 ` Daniel P. Berrange
2016-01-12 12:29 ` [Qemu-devel] [PATCH 4/7] qapi: switch x-input-send-event from console to device+head Gerd Hoffmann
2016-01-12 12:47 ` Daniel P. Berrange
2016-01-15 16:25 ` Markus Armbruster [this message]
2016-01-12 12:29 ` [Qemu-devel] [PATCH 5/7] qapi: rename input buttons Gerd Hoffmann
2016-01-12 12:49 ` Daniel P. Berrange
2016-01-15 16:50 ` Markus Armbruster
2016-01-12 12:29 ` [Qemu-devel] [PATCH 6/7] qapi: rename input axises Gerd Hoffmann
2016-01-12 12:50 ` Daniel P. Berrange
2016-01-15 16:51 ` Markus Armbruster
2016-01-12 12:29 ` [Qemu-devel] [PATCH 7/7] qapi: promote input-send-event to stable Gerd Hoffmann
2016-01-12 12:53 ` Daniel P. Berrange
2016-01-12 13:04 ` Gerd Hoffmann
2016-01-15 16:58 ` Markus Armbruster
2016-01-12 12:42 ` [Qemu-devel] [PATCH 1/7] console: add qemu_console_lookup_by_device_name Daniel P. Berrange
2016-01-15 16:22 ` Markus Armbruster
2016-01-15 16:41 ` Markus Armbruster
2016-01-15 16:45 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4bq4xo2.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).