From: Markus Armbruster <armbru@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Hanna Reitz <hreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH v2 1/3] file-posix: add `aio-max-batch` option
Date: Wed, 27 Oct 2021 06:28:51 +0200 [thread overview]
Message-ID: <87zgqvccqk.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20211026162346.253081-2-sgarzare@redhat.com> (Stefano Garzarella's message of "Tue, 26 Oct 2021 18:23:44 +0200")
Stefano Garzarella <sgarzare@redhat.com> writes:
> Commit d7ddd0a161 ("linux-aio: limit the batch size using
> `aio-max-batch` parameter") added a way to limit the batch size
> of Linux AIO backend for the entire AIO context.
>
> The same AIO context can be shared by multiple devices, so
> latency-sensitive devices may want to limit the batch size even
> more to avoid increasing latency.
>
> For this reason we add the `aio-max-batch` option to the file
> backend, which will be used by the next commits to limit the size of
> batches including requests generated by this device.
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>
> Notes:
> v2:
> - @aio-max-batch documentation rewrite [Stefan, Kevin]
>
> qapi/block-core.json | 7 +++++++
> block/file-posix.c | 9 +++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 6d3217abb6..fef76b0ea2 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2896,6 +2896,12 @@
> # for this device (default: none, forward the commands via SG_IO;
> # since 2.11)
> # @aio: AIO backend (default: threads) (since: 2.8)
> +# @aio-max-batch: maximum number of requests to batch together into a single
> +# submission in the AIO backend. The smallest value between
> +# this and the aio-max-batch value of the IOThread object is
> +# chosen.
> +# 0 means that the AIO backend will handle it automatically.
> +# (default: 0, since 6.2)
"(default 0) (since 6.2)" seems to be more common.
> # @locking: whether to enable file locking. If set to 'auto', only enable
> # when Open File Descriptor (OFD) locking API is available
> # (default: auto, since 2.10)
> @@ -2924,6 +2930,7 @@
> '*pr-manager': 'str',
> '*locking': 'OnOffAuto',
> '*aio': 'BlockdevAioOptions',
> + '*aio-max-batch': 'int',
> '*drop-cache': {'type': 'bool',
> 'if': 'CONFIG_LINUX'},
> '*x-check-cache-dropped': 'bool' },
next prev parent reply other threads:[~2021-10-27 4:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 16:23 [PATCH v2 0/3] linux-aio: allow block devices to limit aio-max-batch Stefano Garzarella
2021-10-26 16:23 ` [PATCH v2 1/3] file-posix: add `aio-max-batch` option Stefano Garzarella
2021-10-27 4:28 ` Markus Armbruster [this message]
2021-10-27 9:23 ` Stefano Garzarella
2021-10-27 13:06 ` Kevin Wolf
2021-10-27 14:50 ` Stefano Garzarella
2021-11-02 11:52 ` Stefano Garzarella
2021-10-27 9:07 ` Stefan Hajnoczi
2021-10-26 16:23 ` [PATCH v2 2/3] linux-aio: add `dev_max_batch` parameter to laio_co_submit() Stefano Garzarella
2021-10-26 16:23 ` [PATCH v2 3/3] linux-aio: add `dev_max_batch` parameter to laio_io_unplug() Stefano Garzarella
2021-11-02 12:07 ` [PATCH v2 0/3] linux-aio: allow block devices to limit aio-max-batch Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgqvccqk.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).