From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966ABC433DB for ; Mon, 22 Mar 2021 12:22:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E58436198E for ; Mon, 22 Mar 2021 12:22:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E58436198E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOJZi-00050L-Qb for qemu-devel@archiver.kernel.org; Mon, 22 Mar 2021 08:22:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOJQ4-0000NP-CC for qemu-devel@nongnu.org; Mon, 22 Mar 2021 08:12:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOJQ0-0007VI-Sd for qemu-devel@nongnu.org; Mon, 22 Mar 2021 08:12:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616415141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ixSeezVGfygokPfWhHchbWLpJKS7oQkAAvb6hou/2/s=; b=ag4EdYsuwchyCNYiOKOsXrR48K0OvVXwwJ3MbdZXz3EYWAeOB86fNDPr40SCsAgMAcRg9q zgh2XsNW78acPcu6Rc6OglKYKFzvEqE905TfWksGicnw8s6hfSpDT5O8wYc1fEOuMFyPvK lKJnLhxtKbHECkaaN7ZYCCOB9E2r3/8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-99-6U4WYZp8NHmgTknejxCtuA-1; Mon, 22 Mar 2021 08:12:18 -0400 X-MC-Unique: 6U4WYZp8NHmgTknejxCtuA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2AC7A1084D68; Mon, 22 Mar 2021 12:12:17 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-17.ams2.redhat.com [10.36.114.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EAC89614FA; Mon, 22 Mar 2021 12:12:16 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7FA7811327E1; Mon, 22 Mar 2021 13:12:15 +0100 (CET) From: Markus Armbruster To: "Zhang, Chen" Subject: Re: [PATCH V4 1/7] qapi/net.json: Add IP_PROTOCOL definition References: <20210319035508.113741-1-chen.zhang@intel.com> <20210319035508.113741-2-chen.zhang@intel.com> <87blbfi1t4.fsf@dusky.pond.sub.org> <12145159a33b4fbc85db2ce6534e62d8@intel.com> Date: Mon, 22 Mar 2021 13:12:15 +0100 In-Reply-To: <12145159a33b4fbc85db2ce6534e62d8@intel.com> (Chen Zhang's message of "Mon, 22 Mar 2021 09:59:54 +0000") Message-ID: <87zgyv4cbk.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lukas Straub , Li Zhijian , Jason Wang , qemu-dev , "Dr. David Alan Gilbert" , Zhang Chen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" "Zhang, Chen" writes: >> -----Original Message----- >> From: Markus Armbruster >> Sent: Friday, March 19, 2021 11:47 PM >> To: Zhang, Chen >> Cc: Jason Wang ; qemu-dev > devel@nongnu.org>; Eric Blake ; Dr. David Alan >> Gilbert ; Li Zhijian ; Lukas >> Straub ; Zhang Chen >> Subject: Re: [PATCH V4 1/7] qapi/net.json: Add IP_PROTOCOL definition >> >> Zhang Chen writes: >> >> > Add IP_PROTOCOL as enum include TCP,UDP, ICMP... for other QMP >> commands. >> > >> > Signed-off-by: Zhang Chen >> > --- >> > qapi/net.json | 31 +++++++++++++++++++++++++++++++ >> > 1 file changed, 31 insertions(+) >> > >> > diff --git a/qapi/net.json b/qapi/net.json index >> > 87361ebd9a..498ea7aa72 100644 >> > --- a/qapi/net.json >> > +++ b/qapi/net.json >> > @@ -794,3 +794,34 @@ >> > # >> > ## >> > { 'command': 'query-netdev', 'returns': ['NetdevInfo'] } >> > + >> > +## >> > +# @IP_PROTOCOL: >> > +# >> > +# Transport layer protocol. >> > +# >> > +# Just for IPv4. >> >> Really? > > Current tcp/udp/icmp field from IPv4 header definition, > I think maybe we need add more to support IPv6. > So, looks change to #TODO support IPv6 part is better? IPv4 and IPv6 share internet protocol numbers. IPv4 has it in header field "protocol", IPv6 in "next header". Canonical registry: https://www.iana.org/assignments/protocol-numbers/protocol-numbers.xhtml >> > +# >> > +# @tcp: Transmission Control Protocol. >> > +# >> > +# @udp: User Datagram Protocol. >> > +# >> > +# @dccp: Datagram Congestion Control Protocol. >> > +# >> > +# @sctp: Stream Control Transmission Protocol. >> > +# >> > +# @udplite: Lightweight User Datagram Protocol. >> > +# >> > +# @icmp: Internet Control Message Protocol. >> > +# >> > +# @igmp: Internet Group Management Protocol. >> > +# >> > +# @ipv6: IPv6 Encapsulation. >> > +# >> > +# TODO: Need to add more transport layer protocol. If there's a need *now*, we should add them now. If the may be a need in the future, then this isn't a TODO. Perhaps # Additional protocols may be added as needed. How did you pick the ones to add now? What if a user wants to use a protocol number not in this enum? If that makes no sense (say because use requires code in QEMU), fine. If it does make sense, we need to talk. You tell me :) >> > +# >> > +# Since: 6.1 >> > +## >> > +{ 'enum': 'IP_PROTOCOL', 'data': [ 'tcp', 'udp', 'dccp', 'sctp', 'udplite', >> > + 'icmp', 'igmp', 'ipv6' ] } >> > + >> >> docs/devel/qapi-code-gen.txt: "type definitions should always use >> CamelCase". >> >> Make this something like 'enum': 'IpProtocol', please. > > OK, I will fix it in next version. > > Thanks > Chen