From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch
Date: Wed, 18 Sep 2019 12:33:18 +0100 [thread overview]
Message-ID: <87zhj1zvnl.fsf@linaro.org> (raw)
In-Reply-To: <93ff7174-77c0-d2eb-eac2-d3eef7e88a14@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> On 9/17/19 5:00 PM, Alex Bennée wrote:
>>>> + add_f32_const(0x8p-152);
>>>> + add_f32_const(0x8p-152);
>>>> + add_f32_const(0x8p-152);
>>>
>>> Why are you adding 3 of the same?
>>
>> To replicate the 1841491 test case where the same number is used for
>> a/b/c
>
> Then we really ought to be more explicit about that.
I guess - I was hoping to piggy back on the general case. Maybe we
should just split that into a separate test case. We can at least re-use
the format and flag printing code and drop the behind the scenes magic
to "join" the constant table with extra test values.
> You're not doing full permutations on the sets of numbers, so does incrementing
> a random index really test what you intended?
I did initially do the full permutation but for madds it all adds up
quite quickly. The shuffle we do here is a bit of a comprise, so it
shuffles the various nan forms before nans with -inf and -large and
finally a bunch of real numbers (subnormals in the middle). It gives a
reasonably broad coverage without going nuts.
>
>>>> +#if defined(__arm__)
>>>> + r = __builtin_fmaf(a, b, c);
>>>> +#else
>>>> + r = __builtin_fmaf(a, b, c);
>>>> +#endif
>>>
>>> Eh?
>>
>> Ahh I was going to hardcode the arm madd instruction in as the builtin
>> wasn't expanding. I tried setting -march in the CFLAGS but that didn't
>> trigger it either on my buster arm-hf compiler. Any ideas how to get the
>> compiler to do the right thing?
>
> I think you want -mfpu=neon-vfpv4.
Ahh that worked. I would have hoped that v8 would be enough to spit out
aarch32 code which has to have VFPv4 for A profile right?
Anyway I'll use that for now.
>
>
> r~
--
Alex Bennée
next prev parent reply other threads:[~2019-09-18 11:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 18:41 [Qemu-devel] [PATCH v1 0/9] testing/next (docker,podman,float) Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 1/9] tests/docker: add sanitizers back to clang build Alex Bennée
2019-09-17 18:43 ` John Snow
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 2/9] tests/docker: fix DOCKER_PARTIAL_IMAGES Alex Bennée
2019-09-17 19:44 ` Philippe Mathieu-Daudé
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 3/9] podman: fix command invocation Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 4/9] target/ppc: fix signal delivery for ppc64abi32 Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 5/9] tests/tcg: clean-up some comments after the de-tangling Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 6/9] tests/tcg: re-enable linux-test for ppc64abi32 Alex Bennée
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 7/9] tests/tcg: add float_madds test to multiarch Alex Bennée
2019-09-17 19:46 ` Richard Henderson
2019-09-17 21:00 ` Alex Bennée
2019-09-17 21:28 ` Richard Henderson
2019-09-18 11:33 ` Alex Bennée [this message]
2019-09-18 15:14 ` Richard Henderson
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 8/9] tests/tcg: add generic version of float_convs Alex Bennée
2019-09-17 19:49 ` Richard Henderson
2019-09-17 20:57 ` Alex Bennée
2019-09-17 21:31 ` Richard Henderson
2019-09-17 18:41 ` [Qemu-devel] [PATCH v1 9/9] tests/tcg: add refs for PPC float_[convs|madds] tests (FAILS TESTS) Alex Bennée
2019-09-18 8:02 ` [Qemu-devel] [PATCH v1 0/9] testing/next (docker, podman, float) no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhj1zvnl.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).