From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: peter.maydell@linaro.org, "Eduardo Habkost" <ehabkost@redhat.com>,
qemu-devel@nongnu.org, "Roman Kagan" <rkagan@virtuozzo.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c
Date: Mon, 24 Jun 2019 14:51:49 +0200 [thread overview]
Message-ID: <87zhm7du3e.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20190624123835.28869-1-alex.bennee@linaro.org>
Alex Bennée <alex.bennee@linaro.org> writes:
> Commit 2d384d7c8 broken the build when built with:
>
> configure --without-default-devices --disable-user
>
> The reason was the conversion of cpu->hyperv_synic to
> cpu->hyperv_synic_kvm_only although the rest of the patch introduces a
> feature checking mechanism. So I've fixed the KVM_EXIT_HYPERV_SYNIC in
> hyperv-stub to do the same feature check as in the real hyperv.c
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Roman Kagan <rkagan@virtuozzo.com>
> ---
> target/i386/hyperv-stub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/i386/hyperv-stub.c b/target/i386/hyperv-stub.c
> index fe548cbae2..0028527e79 100644
> --- a/target/i386/hyperv-stub.c
> +++ b/target/i386/hyperv-stub.c
> @@ -15,7 +15,7 @@ int kvm_hv_handle_exit(X86CPU *cpu, struct kvm_hyperv_exit *exit)
> {
> switch (exit->type) {
> case KVM_EXIT_HYPERV_SYNIC:
> - if (!cpu->hyperv_synic) {
> + if (!hyperv_feat_enabled(cpu, HYPERV_FEAT_SYNIC)) {
> return -1;
> }
As I just sent out exactly the same patch, this probably means the fix
is uncontroversial :-)
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
next prev parent reply other threads:[~2019-06-24 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 12:38 [Qemu-devel] [PATCH] target/i386: fix feature check in hyperv-stub.c Alex Bennée
2019-06-24 12:51 ` Vitaly Kuznetsov [this message]
2019-06-24 13:22 ` Paolo Bonzini
2019-06-24 13:37 ` Paolo Bonzini
2019-06-25 18:41 ` Eduardo Habkost
2019-06-24 13:56 ` Roman Kagan
2019-06-26 15:30 ` Christophe de Dinechin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhm7du3e.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).