From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Taylor Simpson <tsimpson@quicinc.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH] linux-user: Add GPL-2.0+ SPDX license identifier
Date: Thu, 4 Nov 2021 11:02:00 +0100 [thread overview]
Message-ID: <891bd73d-771a-1463-ff2d-5885a6081cd4@amsat.org> (raw)
In-Reply-To: <YYOirmDXpPq16ZMi@redhat.com>
On 11/4/21 10:06, Daniel P. Berrangé wrote:
> On Wed, Nov 03, 2021 at 09:31:46PM +0100, Philippe Mathieu-Daudé wrote:
>> Use Qualcomm License Identifier tool [*] to classify linux-user/
>> files per license type, filtering those matching at least 60% the
>> "GPLv2 or later" type, and manually add the GPL-2.0-or-later SPDX
>> comment.
>
> When you say "manually add", can you confirm that you explicitly
> inspected every license header yourself to validate that the reported
> match truely is GPL-2.0+, before adding the SPDX tag.
>
> Adding licenses tags based merely on a 60% match, without doing
> human inspection would be questionable.
Yes I explicitly inspected every license error before manually add
the tag, but I am human, so prone to errors, which is why peer
review is important :)
This diff is generated using 'git-format-patch --unified=4' because
I thought it would ease review, however I just realize reviewers can't
check from the diff whether there is another license in the file.
In v2 I moved the tag to the first line and generated the diff using
'git-format-patch --unified=20' which is better because in almost all
cases the full header is displayed. I might use '--function-context'
in eventual v3, but it is slightly more verbose (it displays everything
until the first function, so all #include / #define after the header).
next prev parent reply other threads:[~2021-11-04 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 20:31 [PATCH] linux-user: Add GPL-2.0+ SPDX license identifier Philippe Mathieu-Daudé
2021-11-03 20:35 ` Philippe Mathieu-Daudé
2021-11-04 9:06 ` Daniel P. Berrangé
2021-11-04 10:02 ` Philippe Mathieu-Daudé [this message]
2021-11-04 15:17 ` Taylor Simpson
2021-11-04 22:14 ` Philippe Mathieu-Daudé
2021-11-09 16:51 ` Warner Losh
2021-11-09 16:58 ` Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=891bd73d-771a-1463-ff2d-5885a6081cd4@amsat.org \
--to=f4bug@amsat.org \
--cc=berrange@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).