From: Paolo Bonzini <pbonzini@redhat.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 00/10] Migration Arguments cleanup
Date: Mon, 16 Dec 2019 15:01:18 +0100 [thread overview]
Message-ID: <89264106-87af-4fcb-607a-82ad7b56750d@redhat.com> (raw)
In-Reply-To: <20191212222033.1026-1-quintela@redhat.com>
On 12/12/19 23:20, Juan Quintela wrote:
> Hi
>
> This series simplify test_migrate_start() in two ways:
> - simplify the command line creation, so everything that is common between
> architectures don't have to be repeated (DRY).
> Note that this bit remove lines of code.
> - test_migrate_start() has two bools and two strings as arguments, it is very
> difficult to remmeber which is which and meaning. And it is even worse to
> add new parameters. Just pass them through one struct.
>
> Please, review.
>
> Juan Quintela (10):
> migration-test: Create cmd_soure and cmd_target
> migration-test: Move hide_stderr to common commandline
> migration-test: Move -machine to common commandline
> migration-test: Move memory size to common commandline
> migration-test: Move shmem handling to common commandline
> migration-test: Move -name handling to common commandline
> migration-test: Move -serial handling to common commandline
> migration-test: Move -incomming handling to common commandline
> migration-test: Rename cmd_src/dst to arch_source/arch_target
> migration-test: Use a struct for test_migrate_start parameters
>
> tests/migration-test.c | 265 +++++++++++++++++++++++------------------
> 1 file changed, 147 insertions(+), 118 deletions(-)
>
I have picked up this series and rebased the -accel changes on top.
Paolo
next prev parent reply other threads:[~2019-12-16 14:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 22:20 [PATCH 00/10] Migration Arguments cleanup Juan Quintela
2019-12-12 22:20 ` [PATCH 01/10] migration-test: Create cmd_soure and cmd_target Juan Quintela
2019-12-16 13:31 ` Paolo Bonzini
2019-12-16 15:47 ` Juan Quintela
2019-12-12 22:20 ` [PATCH 02/10] migration-test: Move hide_stderr to common commandline Juan Quintela
2019-12-12 22:20 ` [PATCH 03/10] migration-test: Move -machine " Juan Quintela
2019-12-12 22:20 ` [PATCH 04/10] migration-test: Move memory size " Juan Quintela
2019-12-12 22:20 ` [PATCH 05/10] migration-test: Move shmem handling " Juan Quintela
2019-12-12 22:20 ` [PATCH 06/10] migration-test: Move -name " Juan Quintela
2019-12-12 22:20 ` [PATCH 07/10] migration-test: Move -serial " Juan Quintela
2019-12-12 22:20 ` [PATCH 08/10] migration-test: Move -incomming " Juan Quintela
2019-12-12 22:20 ` [PATCH 09/10] migration-test: Rename cmd_src/dst to arch_source/arch_target Juan Quintela
2019-12-12 22:20 ` [PATCH 10/10] migration-test: Use a struct for test_migrate_start parameters Juan Quintela
2019-12-16 13:23 ` [PATCH 00/10] Migration Arguments cleanup Cornelia Huck
2019-12-16 13:48 ` Laurent Vivier
2019-12-16 14:01 ` Paolo Bonzini [this message]
2019-12-16 15:46 ` Juan Quintela
2019-12-16 16:20 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89264106-87af-4fcb-607a-82ad7b56750d@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).