From: Ilya Leoshkevich <iii@linux.ibm.com>
To: "jonathan.albrecht" <jonathan.albrecht@linux.vnet.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org,
Qemu-devel
<qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org>,
Andreas Krebbel <krebbel@linux.ibm.com>
Subject: Re: [PATCH v3 2/2] tests/tcg/s390x: Test SIGILL and SIGSEGV handling
Date: Mon, 21 Jun 2021 13:58:55 +0200 [thread overview]
Message-ID: <8ad1dd217e5894176403e1e5a3a1b2df0920adc2.camel@linux.ibm.com> (raw)
In-Reply-To: <4fe4d6f25ec6c13d70645acd01284cc9@imap.linux.ibm.com>
On Fri, 2021-06-18 at 09:47 -0400, jonathan.albrecht wrote:
> On 2021-06-01 8:22 pm, Ilya Leoshkevich wrote:
> > Verify that s390x-specific uc_mcontext.psw.addr is reported
> > correctly.
> >
> > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> > ---
> > tests/tcg/s390x/Makefile.target | 1 +
> > tests/tcg/s390x/signal.c | 163
> > ++++++++++++++++++++++++++++++++
> > 2 files changed, 164 insertions(+)
> > create mode 100644 tests/tcg/s390x/signal.c
> >
[...]
> > +static void handle_signal(int sig, siginfo_t *info, void
> > *ucontext)
> > +{
> > + void *page;
> > + int err;
> > +
> > + if (sig != expected.sig) {
> > + safe_puts("[ FAILED ] wrong signal");
> > + _exit(1);
> > + }
> > +
> > + if (info->si_addr != expected.addr) {
> > + safe_puts("[ FAILED ] wrong si_addr");
> > + _exit(1);
> > + }
> > +
> > + if (((ucontext_t *)ucontext)->uc_mcontext.psw.addr !=
> > expected.psw_addr) {
> > + safe_puts("[ FAILED ] wrong psw.addr");
> > + _exit(1);
> > + }
> > +
> > + switch (expected.exception) {
>
> When I try to run 'make test-tcg' gcc 9.3.0 is complaining about a
> missing case:
> /home/jalbrecht/src/qemu/tests/tcg/s390x/signal.c: In function
> 'handle_signal':
> /home/jalbrecht/src/qemu/tests/tcg/s390x/signal.c:70:5: error:
> enumeration value 'exception_operation' not handled in switch
> [-Werror=switch]
> 70 | switch (expected.exception) {
> | ^~~~~~
> cc1: all warnings being treated as errors
I wonder how I didn't catch this, since I'm testing on Ubuntu 20.04
as well. Thank you, I will fix this.
Best regards,
Ilya
next prev parent reply other threads:[~2021-06-21 12:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 0:22 [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr reporting Ilya Leoshkevich
2021-06-02 0:22 ` [PATCH v3 1/2] " Ilya Leoshkevich
2021-06-02 0:22 ` [PATCH v3 2/2] tests/tcg/s390x: Test SIGILL and SIGSEGV handling Ilya Leoshkevich
2021-06-18 13:47 ` jonathan.albrecht
2021-06-21 11:58 ` Ilya Leoshkevich [this message]
2021-06-02 0:27 ` [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr reporting no-reply
2021-06-10 9:49 ` David Hildenbrand
2021-06-10 9:53 ` Christian Borntraeger
2021-06-21 12:00 ` Ilya Leoshkevich
2021-06-21 13:12 ` jonathan.albrecht
2021-06-21 13:44 ` Ilya Leoshkevich
2021-06-21 14:46 ` jonathan.albrecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ad1dd217e5894176403e1e5a3a1b2df0920adc2.camel@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=jonathan.albrecht@linux.vnet.ibm.com \
--cc=krebbel@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).