From: Laurent Vivier <laurent@vivier.eu>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [PATCH v1 2/7] linux-user: protect fcntl64 with an #ifdef
Date: Fri, 27 Mar 2020 11:40:21 +0100 [thread overview]
Message-ID: <8c4087ce-3c09-07c5-858b-6c972b85b352@vivier.eu> (raw)
In-Reply-To: <20200327094945.23768-3-alex.bennee@linaro.org>
Le 27/03/2020 à 10:49, Alex Bennée a écrit :
> Checking TARGET_ABI_BITS is sketchy - we should check for the presence
> of the define to be sure. Also clean up the white space while we are
> there.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> linux-user/syscall.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 49395dcea97..a3da46d69f9 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -11223,11 +11223,11 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
> This is a hint, so ignoring and returning success is ok. */
> return 0;
> #endif
> -#if TARGET_ABI_BITS == 32
> +#ifdef TARGET_NR_fcntl64
> case TARGET_NR_fcntl64:
> {
> - int cmd;
> - struct flock64 fl;
> + int cmd;
> + struct flock64 fl;
> from_flock64_fn *copyfrom = copy_from_user_flock64;
> to_flock64_fn *copyto = copy_to_user_flock64;
>
> @@ -11238,7 +11238,7 @@ static abi_long do_syscall1(void *cpu_env, int num, abi_long arg1,
> }
> #endif
>
> - cmd = target_to_host_fcntl_cmd(arg2);
> + cmd = target_to_host_fcntl_cmd(arg2);
> if (cmd == -TARGET_EINVAL) {
> return cmd;
> }
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2020-03-27 10:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 9:49 [PATCH for 5.0 v1 0/7] A selection of sanitiser fixes Alex Bennée
2020-03-27 9:49 ` [PATCH v1 1/7] elf-ops: bail out if we have no function symbols Alex Bennée
2020-03-27 10:53 ` Philippe Mathieu-Daudé
2020-03-27 11:10 ` Philippe Mathieu-Daudé
2020-03-27 11:45 ` Peter Maydell
2020-03-27 22:09 ` Richard Henderson
2020-03-27 9:49 ` [PATCH v1 2/7] linux-user: protect fcntl64 with an #ifdef Alex Bennée
2020-03-27 10:40 ` Laurent Vivier [this message]
2020-03-27 22:10 ` Richard Henderson
2020-03-27 9:49 ` [PATCH v1 3/7] tests/tcg: remove extraneous pasting macros Alex Bennée
2020-03-27 10:54 ` Philippe Mathieu-Daudé
2020-03-27 22:11 ` Richard Henderson
2020-03-27 9:49 ` [PATCH v1 4/7] linux-user: more debug for init_guest_space Alex Bennée
2020-03-27 10:50 ` Laurent Vivier
2020-03-27 9:49 ` [PATCH v1 5/7] fpu/softfloat: avoid undefined behaviour when normalising empty sigs Alex Bennée
2020-03-27 10:09 ` Peter Maydell
2020-03-27 22:27 ` Richard Henderson
2020-03-27 22:33 ` Peter Maydell
2020-03-27 10:13 ` Aleksandar Markovic
2020-03-27 10:31 ` Alex Bennée
2020-03-27 9:49 ` [PATCH v1 6/7] target/xtensa: add FIXME for translation memory leak Alex Bennée
2020-03-27 9:49 ` [PATCH v1 7/7] gdbstub: fix compiler complaining Alex Bennée
2020-03-27 10:56 ` Philippe Mathieu-Daudé
2020-03-27 10:53 ` [PATCH for 5.0 v1 0/7] A selection of sanitiser fixes no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c4087ce-3c09-07c5-858b-6c972b85b352@vivier.eu \
--to=laurent@vivier.eu \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).