From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Ben Widawsky" <ben@bwidawsk.net>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Rohit Shinde" <rohit.shinde12194@gmail.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>, "Fam Zheng" <fam@euphon.net>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 01/15] python: create qemu.core package
Date: Wed, 14 Oct 2020 20:03:55 +0200 [thread overview]
Message-ID: <8e0c4840-43ad-5246-e507-3224398d674c@redhat.com> (raw)
In-Reply-To: <20201014142957.763624-2-jsnow@redhat.com>
On 10/14/20 4:29 PM, John Snow wrote:
> move python/qemu/*.py to python/qemu/core/*.py and update import
> directives across the tree.
>
> This is done to create a PEP420 namespace package, in which we may
> create subpackages. To do this, the namespace directory ("qemu") should
> not have any modules in it. Those files will go in a new 'core'
> subpackage instead.
>
> Bolster the core/__init__.py module, making the top-level classes and
> functions from this package available directly inside the `qemu.core`
> namespace.
>
> This facilitates the convenient shorthand:
>
>> from qemu.core import QEMUQtestMachine, QEMUMonitorProtocol
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/{qemu => }/.isort.cfg | 0
> python/qemu/__init__.py | 11 ------
> python/qemu/{ => core}/.flake8 | 0
> python/qemu/core/__init__.py | 44 +++++++++++++++++++++++
> python/qemu/{ => core}/accel.py | 0
> python/qemu/{ => core}/console_socket.py | 0
> python/qemu/{ => core}/machine.py | 0
> python/qemu/{ => core}/pylintrc | 0
> python/qemu/{ => core}/qmp.py | 0
> python/qemu/{ => core}/qtest.py | 0
> scripts/device-crash-test | 2 +-
> scripts/qmp/qemu-ga-client | 2 +-
> scripts/qmp/qmp | 2 +-
> scripts/qmp/qmp-shell | 2 +-
> scripts/qmp/qom-fuse | 2 +-
> scripts/qmp/qom-get | 2 +-
> scripts/qmp/qom-list | 2 +-
> scripts/qmp/qom-set | 2 +-
> scripts/qmp/qom-tree | 2 +-
> scripts/render_block_graph.py | 6 ++--
> scripts/simplebench/bench_block_job.py | 4 +--
> tests/acceptance/avocado_qemu/__init__.py | 2 +-
> tests/acceptance/boot_linux.py | 3 +-
> tests/acceptance/virtio_check_params.py | 2 +-
> tests/acceptance/virtio_version.py | 2 +-
> tests/migration/guestperf/engine.py | 2 +-
> tests/qemu-iotests/235 | 2 +-
> tests/qemu-iotests/297 | 2 +-
> tests/qemu-iotests/300 | 4 +--
> tests/qemu-iotests/iotests.py | 4 +--
> tests/vm/basevm.py | 6 ++--
> 31 files changed, 71 insertions(+), 41 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-10-14 18:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 14:29 [PATCH v2 00/15] python: create installable package John Snow
2020-10-14 14:29 ` [PATCH v2 01/15] python: create qemu.core package John Snow
2020-10-14 18:03 ` Philippe Mathieu-Daudé [this message]
2020-10-14 14:29 ` [PATCH v2 02/15] python: add qemu package installer John Snow
2020-10-14 14:29 ` [PATCH v2 03/15] python: add VERSION file John Snow
2020-10-14 16:03 ` John Snow
2020-10-19 9:45 ` Andrea Bolognani
2020-10-19 10:02 ` Daniel P. Berrangé
2020-10-19 16:13 ` John Snow
2020-10-20 8:52 ` Andrea Bolognani
2020-10-20 9:06 ` Daniel P. Berrangé
2020-10-20 9:14 ` Andrea Bolognani
2020-10-14 14:29 ` [PATCH v2 04/15] python: add directory structure README.rst files John Snow
2020-10-14 18:05 ` Philippe Mathieu-Daudé
2020-10-14 20:51 ` John Snow
2020-10-14 14:29 ` [PATCH v2 05/15] python: Add pipenv support John Snow
2020-10-14 14:29 ` [PATCH v2 06/15] python: add pylint exceptions to __init__.py John Snow
2020-10-14 14:29 ` [PATCH v2 07/15] python: move pylintrc into setup.cfg John Snow
2020-10-14 14:29 ` [PATCH v2 08/15] python: add pylint to pipenv John Snow
2020-10-14 14:29 ` [PATCH v2 09/15] python: move flake8 config to setup.cfg John Snow
2020-10-14 14:29 ` [PATCH v2 10/15] python: Add flake8 to pipenv John Snow
2020-10-14 14:29 ` [PATCH v2 11/15] python: move mypy.ini into setup.cfg John Snow
2020-10-14 14:29 ` [PATCH v2 12/15] python: add mypy to pipenv John Snow
2020-10-14 14:29 ` [PATCH v2 13/15] python: move .isort.cfg into setup.cfg John Snow
2020-10-14 18:08 ` Philippe Mathieu-Daudé
2020-10-14 14:29 ` [PATCH v2 14/15] python/qemu: add isort to pipenv John Snow
2020-10-14 14:29 ` [PATCH v2 15/15] python/qemu: add qemu package itself " John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e0c4840-43ad-5246-e507-3224398d674c@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=ben@bwidawsk.net \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rohit.shinde12194@gmail.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).