From: Claudio Fontana <cfontana@suse.de>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Roman Bolshakov" <r.bolshakov@yadro.com>,
"Markus Armbruster" <armbru@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, haxm-team@intel.com,
Wenchao Wang <wenchao.wang@intel.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Richard Henderson <rth@twiddle.net>,
Colin Xu <colin.xu@intel.com>
Subject: Re: [PATCH 3/3] cpu-timers, icount: new modules
Date: Fri, 31 Jul 2020 12:59:33 +0200 [thread overview]
Message-ID: <8ea42cd4-02ef-8c5b-7286-bc9db37deba9@suse.de> (raw)
In-Reply-To: <8aaa983a-c720-88f2-5ad4-b88078ef705e@redhat.com>
On 7/31/20 12:09 AM, Paolo Bonzini wrote:
> On 30/07/20 18:33, Claudio Fontana wrote:
>> One problem I noticed is that qemu_clock_get_ns is util/qemu-timer.c,
>> which is tools _and_ softmmu, while I tried to extract the
>> softmmu-only timer code in softmmu/cpu-timers.c,
>
> Not all of it, only the VIRTUAL clock which is
>
> if (use_icount) {
> return cpu_get_icount();
> } else {
> return cpu_get_clock();
> }
>
> and would be changed to something like
>
> return cpu_get_virtual_clock();
>
> In turn cpu_get_virtual_clock() is
>
> return (accel_ops->cpu_get_virtual clock ?: cpu_get_clock)();
>
> in the emulators, plus a stub that replaces stubs/cpu-get-icount.c and
> is just
>
> return get_clock_realtime();
>
> as in stubs/cpu-get-clock.c.
>
> Paolo
>
>
works, hooking up cpu_get_ticks() also works.
qemu_start_warp_timer seems to make sense only for tcg/icount and not for qtest, which directly sets and warps the clock, is that right?
Would you want a start_warp_timer cpu accel interface that is actually useful only for tcg, to avoid if (icount_enabled()) { qemu_start_warp_timer()? }
Thanks,
Claudio
next prev parent reply other threads:[~2020-07-31 11:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 9:35 [PATCH 0/3] QEMU cpus.c refactoring part1 Claudio Fontana
2020-06-29 9:35 ` [PATCH 1/3] softmmu: move softmmu only files from root Claudio Fontana
2020-07-03 17:21 ` Paolo Bonzini
2020-06-29 9:35 ` [PATCH 2/3] cpu-throttle: new module, extracted from cpus.c Claudio Fontana
2020-06-29 9:35 ` [PATCH 3/3] cpu-timers, icount: new modules Claudio Fontana
2020-07-08 14:34 ` Paolo Bonzini
2020-07-08 15:00 ` Claudio Fontana
2020-07-08 15:05 ` Paolo Bonzini
2020-07-08 15:07 ` Thomas Huth
2020-07-08 15:12 ` Paolo Bonzini
2020-07-08 15:15 ` Claudio Fontana
2020-07-08 15:15 ` Thomas Huth
2020-07-08 15:17 ` Claudio Fontana
2020-07-08 15:23 ` Paolo Bonzini
2020-07-08 15:30 ` Claudio Fontana
2020-07-09 18:38 ` Claudio Fontana
2020-07-09 18:46 ` Claudio Fontana
2020-07-10 6:33 ` Cornelia Huck
2020-07-10 19:20 ` Claudio Fontana
2020-07-13 10:46 ` Cornelia Huck
2020-07-11 11:40 ` Claudio Fontana
2020-07-13 10:51 ` Cornelia Huck
2020-07-13 11:27 ` Claudio Fontana
2020-07-10 4:36 ` Thomas Huth
2020-07-10 22:45 ` Paolo Bonzini
2020-07-11 9:14 ` Claudio Fontana
2020-07-11 9:39 ` Paolo Bonzini
2020-07-11 11:49 ` Claudio Fontana
2020-07-11 12:19 ` Paolo Bonzini
2020-07-11 12:48 ` Claudio Fontana
2020-07-29 8:48 ` Claudio Fontana
2020-07-29 10:01 ` Paolo Bonzini
2020-07-30 16:33 ` Claudio Fontana
2020-07-30 22:09 ` Paolo Bonzini
2020-07-31 10:59 ` Claudio Fontana [this message]
2020-07-02 6:27 ` [PATCH 0/3] QEMU cpus.c refactoring part1 Claudio Fontana
2020-07-03 17:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ea42cd4-02ef-8c5b-7286-bc9db37deba9@suse.de \
--to=cfontana@suse.de \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=colin.xu@intel.com \
--cc=ehabkost@redhat.com \
--cc=haxm-team@intel.com \
--cc=lvivier@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=rth@twiddle.net \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=wenchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).