From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH v4 05/11] rules.mak: Add base-arch() rule
Date: Mon, 1 Jun 2020 09:26:44 +0200 [thread overview]
Message-ID: <8ed29bf2-4687-9ee7-c209-fd03faac555e@redhat.com> (raw)
In-Reply-To: <9e83f0de-871b-9fc7-6489-d4a94ff0066c@linaro.org>
On 6/1/20 4:13 AM, Richard Henderson wrote:
> On 5/22/20 9:37 AM, Philippe Mathieu-Daudé wrote:
>> + $(if $(call startwith,risc,$1),risc,\
>
> Should be "riscv" not "risc". Especially the substitution.
Indeed.
>
>> + $(if $(call startwith,aarch64,$1),arm,\
>> + $(if $(call startwith,x86_64,$1),i386,\
>
> We don't have an exact equality function?
There is this one which returns y/n:
# String testing functions: inputs to these can be any string;
# the output is always either "y" or "n". Leading and trailing whitespace
# is ignored when comparing strings.
# String equality
eq = $(if $(subst $2,,$1)$(subst $1,,$2),n,y)
I'll add a simpler strequal().
next prev parent reply other threads:[~2020-06-01 7:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 16:37 [PATCH v4 00/11] accel: Allow targets to use Kconfig Philippe Mathieu-Daudé
2020-05-22 16:37 ` [PATCH v4 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-05-22 16:37 ` [PATCH v4 02/11] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-05-22 16:37 ` [PATCH v4 03/11] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
2020-05-22 16:43 ` Philippe Mathieu-Daudé
2020-05-22 16:37 ` [PATCH v4 04/11] rules.mak: Add startwith() rule Philippe Mathieu-Daudé
2020-05-22 16:37 ` [PATCH v4 05/11] rules.mak: Add base-arch() rule Philippe Mathieu-Daudé
2020-06-01 2:13 ` Richard Henderson
2020-06-01 7:26 ` Philippe Mathieu-Daudé [this message]
2020-06-05 7:27 ` Philippe Mathieu-Daudé
2020-05-22 16:37 ` [PATCH v4 06/11] Makefile: Remove dangerous EOL trailing backslash Philippe Mathieu-Daudé
2020-05-22 16:37 ` [PATCH v4 07/11] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
2020-05-22 16:37 ` [PATCH v4 08/11] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-05-22 16:37 ` [PATCH v4 09/11] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-05-22 16:37 ` [PATCH v4 10/11] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-05-22 16:37 ` [PATCH v4 11/11] accel/tcg: Add stub for probe_access() Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ed29bf2-4687-9ee7-c209-fd03faac555e@redhat.com \
--to=philmd@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).