From: Damien Hedde <damien.hedde@greensocs.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: luis.machado@linaro.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
richard.henderson@linaro.org, alan.hayward@arm.com
Subject: Re: [PATCH v2 04/14] gdbstub: move mem_buf to GDBState and use GByteArray
Date: Tue, 3 Dec 2019 12:11:07 +0100 [thread overview]
Message-ID: <8f9519f0-78f7-707a-007f-71be24339477@greensocs.com> (raw)
In-Reply-To: <20191130084602.10818-5-alex.bennee@linaro.org>
On 11/30/19 9:45 AM, Alex Bennée wrote:
> This is in preparation for further re-factoring of the register API
> with the rest of the code. Theoretically the read register function
> could overwrite the MAX_PACKET_LENGTH buffer although currently all
> registers are well within the size range.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> gdbstub.c | 62 ++++++++++++++++++++++++++++++++++---------------------
> 1 file changed, 38 insertions(+), 24 deletions(-)
>
> @@ -2003,7 +2015,7 @@ static void handle_query_curr_tid(GdbCmdContext *gdb_ctx, void *user_ctx)
> cpu = get_first_cpu_in_process(process);
> g_string_assign(gdbserver_state.str_buf, "QC");
> gdb_append_thread_id(cpu, gdbserver_state.str_buf);
> - put_strbuf();;
> + put_strbuf();
Hi Alex,
The double ';' (and the two other occurrences below) is added by your
previous patch.
> }
>
> static void handle_query_threads(GdbCmdContext *gdb_ctx, void *user_ctx)
> @@ -2015,7 +2027,7 @@ static void handle_query_threads(GdbCmdContext *gdb_ctx, void *user_ctx)
>
> g_string_assign(gdbserver_state.str_buf, "m");
> gdb_append_thread_id(gdbserver_state.query_cpu, gdbserver_state.str_buf);
> - put_strbuf();;
> + put_strbuf();
> gdbserver_state.query_cpu = gdb_next_attached_cpu(gdbserver_state.query_cpu);
> }
>
> @@ -2058,7 +2070,7 @@ static void handle_query_thread_extra(GdbCmdContext *gdb_ctx, void *user_ctx)
> }
> trace_gdbstub_op_extra_info(rs->str);
> memtohex(gdbserver_state.str_buf, (uint8_t *)rs->str, rs->len);
> - put_strbuf();;
> + put_strbuf();
> }
>
With the ";;" fix
Reviewed/Tested-by: Damien Hedde <damien.hedde@greensocs>
--
Damien
next prev parent reply other threads:[~2019-12-03 11:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-30 8:45 [PATCH v2 00/14] gdbstub refactor and SVE support Alex Bennée
2019-11-30 8:45 ` [PATCH v2 01/14] gdbstub: make GDBState static and have common init function Alex Bennée
2019-12-02 2:14 ` Richard Henderson
2019-12-02 14:35 ` Damien Hedde
2019-11-30 8:45 ` [PATCH v2 02/14] gdbstub: stop passing GDBState * around and use global Alex Bennée
2019-12-02 2:16 ` Richard Henderson
2019-12-02 15:25 ` Damien Hedde
2019-11-30 8:45 ` [PATCH v2 03/14] gdbstub: move str_buf to GDBState and use GString Alex Bennée
2019-12-02 15:26 ` Damien Hedde
2019-12-03 12:49 ` Damien Hedde
2019-11-30 8:45 ` [PATCH v2 04/14] gdbstub: move mem_buf to GDBState and use GByteArray Alex Bennée
2019-12-03 11:11 ` Damien Hedde [this message]
2019-11-30 8:45 ` [PATCH v2 05/14] gdbstub: add helper for 128 bit registers Alex Bennée
2019-12-01 20:02 ` Philippe Mathieu-Daudé
2019-12-02 2:19 ` Richard Henderson
2019-11-30 8:45 ` [PATCH v2 06/14] target/arm: use gdb_get_reg helpers Alex Bennée
2019-12-01 20:05 ` Philippe Mathieu-Daudé
2019-12-02 10:05 ` Alan Hayward
2019-12-05 17:58 ` Alex Bennée
2019-12-02 2:20 ` Richard Henderson
2019-11-30 8:45 ` [PATCH v2 07/14] target/m68k: " Alex Bennée
2019-11-30 10:58 ` Laurent Vivier
2019-11-30 8:45 ` [PATCH v2 08/14] gdbstub: extend GByteArray to read register helpers Alex Bennée
2019-12-02 2:24 ` Richard Henderson
2019-11-30 8:45 ` [PATCH v2 09/14] target/arm: prepare for multiple dynamic XMLs Alex Bennée
2019-12-02 18:26 ` Richard Henderson
2019-11-30 8:45 ` [PATCH v2 10/14] target/arm: explicitly encode regnum in our XML Alex Bennée
2019-11-30 8:45 ` [PATCH v2 11/14] target/arm: default SVE length to 64 bytes for linux-user Alex Bennée
2019-12-02 2:41 ` Richard Henderson
2019-12-05 17:31 ` Alex Bennée
2019-12-05 19:36 ` Richard Henderson
2019-12-06 14:52 ` Alex Bennée
2019-11-30 8:46 ` [PATCH v2 12/14] target/arm: generate xml description of our SVE registers Alex Bennée
2019-12-02 18:44 ` Richard Henderson
2019-11-30 8:46 ` [PATCH v2 13/14] tests/guest-debug: add a simple test runner Alex Bennée
2019-12-02 18:50 ` Richard Henderson
2019-11-30 8:46 ` [PATCH v2 14/14] tests/tcg: add a gdbstub testcase for SVE registers Alex Bennée
2019-11-30 9:33 ` [PATCH v2 00/14] gdbstub refactor and SVE support no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f9519f0-78f7-707a-007f-71be24339477@greensocs.com \
--to=damien.hedde@greensocs.com \
--cc=alan.hayward@arm.com \
--cc=alex.bennee@linaro.org \
--cc=luis.machado@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).