From: John Snow <jsnow@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 3/7] iotests: Keep testing broken relative extent paths
Date: Mon, 12 Aug 2019 16:21:14 -0400 [thread overview]
Message-ID: <9020e578-12c0-7c33-1679-55ba7932a606@redhat.com> (raw)
In-Reply-To: <20190725155735.11872-4-mreitz@redhat.com>
On 7/25/19 11:57 AM, Max Reitz wrote:
> We had a test for a case where relative extent paths did not work, but
> unfortunately we just fixed the underlying problem, so it works now.
> This patch adds a new test case that still fails.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/059 | 27 +++++++++++++++++++++++++++
> tests/qemu-iotests/059.out | 4 ++++
> 2 files changed, 31 insertions(+)
>
> diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059
> index fbed5f9483..2a883d0f21 100755
> --- a/tests/qemu-iotests/059
> +++ b/tests/qemu-iotests/059
> @@ -114,6 +114,8 @@ $QEMU_IMG convert -f qcow2 -O vmdk -o subformat=streamOptimized "$TEST_IMG.qcow2
>
> echo
> echo "=== Testing monolithicFlat with internally generated JSON file name ==="
> +
> +echo '--- blkdebug ---'
> # Should work, because bdrv_dirname() works fine with blkdebug
^
> IMGOPTS="subformat=monolithicFlat" _make_test_img 64M
> $QEMU_IO -c "open -o driver=$IMGFMT,file.driver=blkdebug,file.image.filename=$TEST_IMG,file.inject-error.0.event=read_aio" \
> @@ -122,6 +124,31 @@ $QEMU_IO -c "open -o driver=$IMGFMT,file.driver=blkdebug,file.image.filename=$TE
> | _filter_testdir | _filter_imgfmt | _filter_img_info
> _cleanup_test_img
>
> +echo '--- quorum ---'
> +# Should not work, because bdrv_dirname() does not work with blkdebug
^ ? So uh, which is it?
(you wanted: s/blkdebug/quorum/)
> +IMGOPTS="subformat=monolithicFlat" _make_test_img 64M
> +cp "$TEST_IMG" "$TEST_IMG.orig"
> +
> +filename="json:{
> + \"driver\": \"$IMGFMT\",
> + \"file\": {
> + \"driver\": \"quorum\",
> + \"children\": [ {
> + \"driver\": \"file\",
> + \"filename\": \"$TEST_IMG\"
> + }, {
> + \"driver\": \"file\",
> + \"filename\": \"$TEST_IMG.orig\"
> + } ],
> + \"vote-threshold\": 1
> + } }"
> +
> +filename=$(echo "$filename" | tr '\n' ' ' | sed -e 's/\s\+/ /g')
> +$QEMU_IMG info "$filename" 2>&1 \
> + | sed -e "s/'json:[^']*'/\$QUORUM_FILE/g" \
> + | _filter_testdir | _filter_imgfmt | _filter_img_info
> +
> +
> echo
> echo "=== Testing version 3 ==="
> _use_sample_img iotest-version3.vmdk.bz2
> diff --git a/tests/qemu-iotests/059.out b/tests/qemu-iotests/059.out
> index 120cddd207..f8895ba434 100644
> --- a/tests/qemu-iotests/059.out
> +++ b/tests/qemu-iotests/059.out
> @@ -2049,10 +2049,14 @@ wrote 512/512 bytes at offset 10240
> 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>
> === Testing monolithicFlat with internally generated JSON file name ===
> +--- blkdebug ---
> Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
> format name: IMGFMT
> cluster size: 0 bytes
> vm state offset: 0 bytes
> +--- quorum ---
> +Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
> +qemu-img: Could not open $QUORUM_FILE: Cannot use relative paths with VMDK descriptor file $QUORUM_FILE: Cannot generate a base directory for quorum nodes
>
> === Testing version 3 ===
> image: TEST_DIR/iotest-version3.IMGFMT
>
With the paste-o fixed:
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2019-08-12 20:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 15:57 [Qemu-devel] [PATCH 0/7] vmdk: Misc fixes Max Reitz
2019-07-25 15:57 ` [Qemu-devel] [PATCH 1/7] iotests: Fix _filter_img_create() Max Reitz
2019-08-12 19:32 ` [Qemu-devel] [Qemu-block] " John Snow
2019-07-25 15:57 ` [Qemu-devel] [PATCH 2/7] vmdk: Use bdrv_dirname() for relative extent paths Max Reitz
2019-08-12 20:17 ` [Qemu-devel] [Qemu-block] " John Snow
2019-07-25 15:57 ` [Qemu-devel] [PATCH 3/7] iotests: Keep testing broken " Max Reitz
2019-08-12 20:21 ` John Snow [this message]
2019-07-25 15:57 ` [Qemu-devel] [PATCH 4/7] vmdk: Reject invalid compressed writes Max Reitz
2019-08-12 20:26 ` [Qemu-devel] [Qemu-block] " John Snow
2019-08-12 21:03 ` Max Reitz
2019-08-12 21:16 ` John Snow
2019-08-13 12:58 ` Max Reitz
2019-07-25 15:57 ` [Qemu-devel] [PATCH 5/7] iotests: Disable broken streamOptimized tests Max Reitz
2019-07-25 15:57 ` [Qemu-devel] [PATCH 6/7] iotests: Disable 110 for vmdk.twoGbMaxExtentSparse Max Reitz
2019-08-12 21:26 ` [Qemu-devel] [Qemu-block] " John Snow
2019-07-25 15:57 ` [Qemu-devel] [PATCH 7/7] iotests: Disable 126 for some vmdk subformats Max Reitz
2019-07-25 17:00 ` Eric Blake
2019-07-26 7:52 ` Max Reitz
2019-08-12 21:33 ` [Qemu-devel] [Qemu-block] " John Snow
2019-08-13 14:00 ` Max Reitz
2019-08-13 22:26 ` John Snow
2019-08-14 14:01 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9020e578-12c0-7c33-1679-55ba7932a606@redhat.com \
--to=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).