From: "Zhang, Chen" <chen.zhang@intel.com>
To: "Rao, Lei" <lei.rao@intel.com>,
"lizhijian@cn.fujitsu.com" <lizhijian@cn.fujitsu.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"quintela@redhat.com" <quintela@redhat.com>,
"dgilbert@redhat.com" <dgilbert@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"lukasstraub2@web.de" <lukasstraub2@web.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: RE: [PATCH v5 02/10] Fix the qemu crash when guest shutdown during checkpoint
Date: Thu, 8 Apr 2021 05:21:59 +0000 [thread overview]
Message-ID: <90e9f537e1ad40c28afcabfe832bc2fd@intel.com> (raw)
In-Reply-To: <1617263249-54501-3-git-send-email-lei.rao@intel.com>
> -----Original Message-----
> From: Rao, Lei <lei.rao@intel.com>
> Sent: Thursday, April 1, 2021 3:47 PM
> To: Zhang, Chen <chen.zhang@intel.com>; lizhijian@cn.fujitsu.com;
> jasowang@redhat.com; quintela@redhat.com; dgilbert@redhat.com;
> pbonzini@redhat.com; lukasstraub2@web.de
> Cc: qemu-devel@nongnu.org; Rao, Lei <lei.rao@intel.com>
> Subject: [PATCH v5 02/10] Fix the qemu crash when guest shutdown during
> checkpoint
>
> From: "Rao, Lei" <lei.rao@intel.com>
>
> This patch fixes the following:
> qemu-system-x86_64: invalid runstate transition: 'colo' ->'shutdown'
> Aborted (core dumped)
>
> Signed-off-by: Lei Rao <lei.rao@intel.com>
> Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
> ---
> softmmu/runstate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/softmmu/runstate.c b/softmmu/runstate.c index
> ce8977c..1564057 100644
> --- a/softmmu/runstate.c
> +++ b/softmmu/runstate.c
> @@ -126,6 +126,7 @@ static const RunStateTransition
> runstate_transitions_def[] = {
> { RUN_STATE_RESTORE_VM, RUN_STATE_PRELAUNCH },
>
> { RUN_STATE_COLO, RUN_STATE_RUNNING },
> + { RUN_STATE_COLO, RUN_STATE_SHUTDOWN},
>
> { RUN_STATE_RUNNING, RUN_STATE_DEBUG },
> { RUN_STATE_RUNNING, RUN_STATE_INTERNAL_ERROR },
> --
> 1.8.3.1
next prev parent reply other threads:[~2021-04-08 5:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 7:47 [PATCH v5 00/10] Fixed some bugs and optimized some codes for COLO leirao
2021-04-01 7:47 ` [PATCH v5 01/10] Remove some duplicate trace code leirao
2021-04-08 5:21 ` Zhang, Chen
2021-04-01 7:47 ` [PATCH v5 02/10] Fix the qemu crash when guest shutdown during checkpoint leirao
2021-04-08 5:21 ` Zhang, Chen [this message]
2021-04-01 7:47 ` [PATCH v5 03/10] Optimize the function of filter_send leirao
2021-04-08 5:23 ` Zhang, Chen
2021-04-01 7:47 ` [PATCH v5 04/10] Remove migrate_set_block_enabled in checkpoint leirao
2021-04-08 5:25 ` Zhang, Chen
2021-04-01 7:47 ` [PATCH v5 05/10] Add a function named packet_new_nocopy for COLO leirao
2021-04-08 5:30 ` Zhang, Chen
2021-04-01 7:47 ` [PATCH v5 06/10] Add the function of colo_compare_cleanup leirao
2021-04-08 8:48 ` Zhang, Chen
2021-04-01 7:47 ` [PATCH v5 07/10] Reset the auto-converge counter at every checkpoint leirao
2021-04-01 7:47 ` [PATCH v5 08/10] Reduce the PVM stop time during Checkpoint leirao
2021-04-01 7:47 ` [PATCH v5 09/10] Add the function of colo_bitmap_clear_dirty leirao
2021-04-01 7:47 ` [PATCH v5 10/10] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info() leirao
2021-04-08 8:49 ` Zhang, Chen
2021-04-04 10:22 ` [PATCH v5 00/10] Fixed some bugs and optimized some codes for COLO Lukas Straub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e9f537e1ad40c28afcabfe832bc2fd@intel.com \
--to=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=lei.rao@intel.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=lukasstraub2@web.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).